Fixes #1722 - function app's setting read

[DexterPOSH]

PR to fix the read of Function App's settings #1722
It is based on the suggestion in the same email thread. Catching if the response is not found and returning a nil (should it be nil?) or it should be an if-else block like below:

appSettingsResp, err := client.ListApplicationSettings(ctx, resGroup, name)
	if err != nil {
		if utils.ResponseWasNotFound(appSettingsResp.Response) {
			log.Printf("[DEBUG] Application Settings of Function App %q (resource group %q) were not found", name, resGroup)
		} else {
			return fmt.Errorf("Error making Read request on AzureRM Function App AppSettings %q: %+v", name, err)
		}
	}

(Fixes #1722)

[katbyte]

Hi @DexterPOSH,

Thanks for the fix! It's almost there, along with not returning an error when the resource is not found we need to set the ID to nil marking it as missing in terraform. I've left a comment inline with the suggested code.

Once that is added this'll be good to merge 🙂

[katbyte]

(also just a FYI, putting fixes #1722 in the description will cause that issue to be closed when this is merged)

[katbyte]

Thanks for the update @DexterPOSH! LGTM now 👍

[tombuildsstuff]

hi @DexterPOSH

Just to let you know that this has been released as a part of v1.18 of the AzureRM Provider (the full changelog is available here). You can upgrade to this by specifying the version in the provider block (as shown below) and then running terraform init -upgrade

provider "azurerm" {
  version = "=1.18.0"
}

Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!