Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing hard-coded test data failures identified against Azure Germany #237

Merged
merged 4 commits into from
Aug 11, 2017

Conversation

tombuildsstuff
Copy link
Contributor

  • Registering the CosmosDB (DocumentDB) Resource Provider
  • Upgrading the examples to Ubuntu 16.04, since 14.04.2 isn't available in Azure Germany
  • Exposing the Azure Environment in order to be able to get the DNS Suffixes for tests

@tombuildsstuff
Copy link
Contributor Author

tombuildsstuff commented Aug 10, 2017

The OS upgrade passes against Azure Public (West US) and Azure Germany:

$ TF_ACC=1 envchain azurerm go test ./azurerm -v -timeout 120m -run TestAccAzureRMVirtualMachine_basicLinuxMachine_managedDisk_explicit
=== RUN   TestAccAzureRMVirtualMachine_basicLinuxMachine_managedDisk_explicit
--- PASS: TestAccAzureRMVirtualMachine_basicLinuxMachine_managedDisk_explicit (557.19s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	557.220s

Traffic Manager tests too:

 $ TF_ACC=1 envchain azurerm go test ./azurerm -v -timeout 120m -run TestAccAzureRMTrafficManagerProfile_weighted
=== RUN   TestAccAzureRMTrafficManagerProfile_weighted
--- PASS: TestAccAzureRMTrafficManagerProfile_weighted (69.73s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	69.745s

Copy link
Contributor

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 assuming tests pass

@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants