Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort data sources and resources map keys #2638

Merged
merged 2 commits into from
Jan 10, 2019
Merged

Sort data sources and resources map keys #2638

merged 2 commits into from
Jan 10, 2019

Conversation

inkel
Copy link
Contributor

@inkel inkel commented Jan 10, 2019

This PR sorts alphabetically the keys in the provider's DataSourcesMap and ResourcesMap.

Additionally it also formats ResourcesMap using go fmt, so perhaps it's best to review the changes without including whitespace only changes.

This one was first identified in a different PR.

@ghost ghost added the size/L label Jan 10, 2019
@katbyte katbyte added this to the 1.21.0 milestone Jan 10, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this refactoring @inkel! it is very much appreciated, LGTM 💯

@ghost ghost added size/M and removed size/L labels Jan 10, 2019
@katbyte
Copy link
Collaborator

katbyte commented Jan 10, 2019

I hope you don't mind but I pushed some changes to fix the build 🙂

@katbyte katbyte merged commit 98ca477 into hashicorp:master Jan 10, 2019
@inkel inkel deleted the sort-provider-item-names branch January 10, 2019 13:26
@inkel
Copy link
Contributor Author

inkel commented Jan 10, 2019

I hope you don't mind but I pushed some changes to fix the build 🙂

Not at all! I wasn't aware of that command either. Perhaps it'd be nice to have that information in the README or in .github/CONTRIBUTING.md, so all people sending PR's is aware of that.

@ghost
Copy link

ghost commented Mar 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants