Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_container_app - support for the add sub_path property #27533

Merged
merged 3 commits into from
Feb 7, 2025
Merged

azurerm_container_app - support for the add sub_path property #27533

merged 3 commits into from
Feb 7, 2025

Conversation

stergem
Copy link
Contributor

@stergem stergem commented Sep 29, 2024

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevent documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_container_app - Support for subPath in volumeMounts [GH-00000]

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #23765

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@katbyte katbyte changed the title add sub_path property to container app volume_mount azurerm_container_app - support for the add sub_path property Oct 17, 2024
katbyte
katbyte previously approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stergem - LGTM 🍨

jackofallops
jackofallops previously requested changes Oct 17, 2024
View reviewed changes
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @stergem - Spotted a small problem while skimming through, can you take a look at the below?

Thanks!

@katbyte katbyte requested a review from a team as a code owner November 14, 2024 00:08
@stergem stergem requested a review from jackofallops December 5, 2024 14:38
stephybun
stephybun approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests look good, thanks for this @stergem LGTM 👍

@stephybun stephybun merged commit acd0890 into hashicorp:main Feb 7, 2025
3 checks passed
@github-actions github-actions bot added this to the v4.18.0 milestone Feb 7, 2025
stephybun added a commit that referenced this pull request Feb 7, 2025
@stephybun
Update for #27533
94553e2
jackofallops added a commit that referenced this pull request Feb 7, 2025
@jackofallops @stephybun
@sreallymatt @WodansSon
CHANGELOG.md for v4.18.0 (#28651)
4d8df7f 
* CHANGELOG.md for v4.18.0

* Update CHANGELOG.md for #28308

* Update for #28447

* Update for #28532

* Update for #28537

* Update CHANGELOG.md for #28674

* Update for #28363

* Update for #28536

* Update for #28416

* Update CHANGELOG.md #28700

* Update for #28673

* Update for #28308

Co-authored-by: Wodans Son <[email protected]>

* Update for #27533

* prep for release

---------

Co-authored-by: stephybun <[email protected]>
Co-authored-by: sreallymatt <[email protected]>
Co-authored-by: Wodans Son <[email protected]>
@stergem stergem deleted the volume-mount-subpath branch February 17, 2025 08:27
hqhqhqhqhqhqhqhqhqhqhq pushed a commit to hqhqhqhqhqhqhqhqhqhqhq/terraform-provider-azurerm that referenced this pull request Feb 26, 2025
@stergem @katbyte
@jackofallops @hqhqhqhqhqhqhqhqhqhqhq
azurerm_container_app - support for the add sub_path property (hash…
65145e6 
…icorp#27533)

* add sub_path property to container app volume_mount

* Update internal/services/containerapps/container_app_resource_test.go

* Update internal/services/containerapps/helpers/container_apps.go

Co-authored-by: jackofallops <[email protected]>

---------

Co-authored-by: Stergios Gemelas <[email protected]>
Co-authored-by: kt <[email protected]>
Co-authored-by: jackofallops <[email protected]>
hqhqhqhqhqhqhqhqhqhqhq pushed a commit to hqhqhqhqhqhqhqhqhqhqhq/terraform-provider-azurerm that referenced this pull request Feb 26, 2025
@jackofallops @stephybun
@sreallymatt @WodansSon @hqhqhqhqhqhqhqhqhqhqhq
CHANGELOG.md for v4.18.0 (hashicorp#28651)
fb005c2 
* CHANGELOG.md for v4.18.0

* Update CHANGELOG.md for hashicorp#28308

* Update for hashicorp#28447

* Update for hashicorp#28532

* Update for hashicorp#28537

* Update CHANGELOG.md for hashicorp#28674

* Update for hashicorp#28363

* Update for hashicorp#28536

* Update for hashicorp#28416

* Update CHANGELOG.md hashicorp#28700

* Update for hashicorp#28673

* Update for hashicorp#28308

Co-authored-by: Wodans Son <[email protected]>

* Update for hashicorp#27533

* prep for release

---------

Co-authored-by: stephybun <[email protected]>
Co-authored-by: sreallymatt <[email protected]>
Co-authored-by: Wodans Son <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katbyte katbyte katbyte left review comments

@stephybun stephybun stephybun approved these changes

@jackofallops jackofallops Awaiting requested review from jackofallops

Assignees
No one assigned
Labels
documentation enhancement good first issue service/container-apps size/S
Projects
None yet
Milestone
v4.18.0
Development

Successfully merging this pull request may close these issues.

azurerm_container_app: Support for subPath in volumeMounts
5 participants
@stergem @katbyte @jackofallops @stephybun @rcskosir