-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug Fix ] azurerm_redis_cache
- Support for unsetting data_persistence_authentication_method
#27932
[Bug Fix ] azurerm_redis_cache
- Support for unsetting data_persistence_authentication_method
#27932
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @xuzhang3 - I left one minor comment on this but can take another look once it is addressed. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @xuzhang3 LGTM!
* update for #27680 * Update CHANGELOG.md for #28465 * Update CHANGELOG.md #27932 * Update CHANGELOG.md for #28505 * Update CHANGELOG.md for #28474 * Update CHANGELOG.md #28516 * Update CHANGELOG for #28456 * Update CHANGELOG.md for #28472 * Update CHANGELOG.md #28307 * Update CHANGELOG.md for #27859 * Update for #28519 * Update for #27791 #27528 * Update CHANGELOG.md for #28527 * update changelog links and generate provider schema --------- Co-authored-by: jackofallops <[email protected]> Co-authored-by: catriona-m <[email protected]> Co-authored-by: sreallymatt <[email protected]> Co-authored-by: Matthew Frahry <[email protected]> Co-authored-by: jackofallops <[email protected]>
…tence_authentication_method` (hashicorp#27932) * support for unsetting data_persistence_authentication_method * optimize data_persistence_authentication_method settings
* update for hashicorp#27680 * Update CHANGELOG.md for hashicorp#28465 * Update CHANGELOG.md hashicorp#27932 * Update CHANGELOG.md for hashicorp#28505 * Update CHANGELOG.md for hashicorp#28474 * Update CHANGELOG.md hashicorp#28516 * Update CHANGELOG for hashicorp#28456 * Update CHANGELOG.md for hashicorp#28472 * Update CHANGELOG.md hashicorp#28307 * Update CHANGELOG.md for hashicorp#27859 * Update for hashicorp#28519 * Update for hashicorp#27791 hashicorp#27528 * Update CHANGELOG.md for hashicorp#28527 * update changelog links and generate provider schema --------- Co-authored-by: jackofallops <[email protected]> Co-authored-by: catriona-m <[email protected]> Co-authored-by: sreallymatt <[email protected]> Co-authored-by: Matthew Frahry <[email protected]> Co-authored-by: jackofallops <[email protected]>
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Support unset
data_persistence_authentication_method
Community Note
Description
PR Checklist
For example: “
resource_name_here
- description of change e.g. adding propertynew_property_name_here
”Changes to existing Resource / Data Source
Testing
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_resource
- support for thething1
property [GH-00000]This is a (please select all that apply):
Related Issue(s)
Fixes #27878
Note
If this PR changes meaningfully during the course of review please update the title and description as required.