Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_mssql_elasticpool - Fix for creating hyperscale elastic pool of type MOPRMS and PRMS #28453

Merged
merged 1 commit into from
Jan 27, 2025
Merged

azurerm_mssql_elasticpool - Fix for creating hyperscale elastic pool of type MOPRMS and PRMS #28453

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 46 additions & 26 deletions internal/services/mssql/helper/elasticpool.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,34 +201,52 @@ var getvCoreMaxGB = map[string]map[string]map[int]float64{
},
"hyperscale": {
"gen5": {
4: 1024,
6: 1536,
8: 2048,
10: 2048,
12: 3072,
14: 3072,
16: 3072,
18: 3072,
20: 3072,
24: 4096,
32: 4096,
40: 4096,
80: 4096,
4: 128000,
6: 128000,
8: 128000,
10: 128000,
12: 128000,
14: 128000,
16: 128000,
18: 128000,
20: 128000,
24: 128000,
32: 128000,
40: 128000,
80: 128000,
},
"prms": {
4: 1024,
6: 1536,
8: 2048,
10: 2048,
12: 3072,
14: 3072,
16: 3072,
18: 3072,
20: 3072,
24: 4096,
32: 4096,
40: 4096,
80: 4096,
4: 128000,
6: 128000,
8: 128000,
10: 128000,
12: 128000,
14: 128000,
16: 128000,
18: 128000,
20: 128000,
24: 128000,
32: 128000,
40: 128000,
64: 128000,
80: 128000,
128: 128000,
},
Comment on lines +204 to +234
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe these should be changed to some arbitrary maximum value

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stephybun They are not set to arbitrary maximum value. They are set to 128TB see https://learn.microsoft.com/en-us/azure/azure-sql/database/resource-limits-vcore-single-databases?view=azuresql#hyperscale---provisioned-compute---gen5 for more details.

"moprms": {
4: 128000,
6: 128000,
8: 128000,
10: 128000,
12: 128000,
14: 128000,
16: 128000,
18: 128000,
20: 128000,
24: 128000,
32: 128000,
40: 128000,
64: 128000,
80: 128000,
Comment on lines +236 to +249
Copy link
Member

@stephybun stephybun Jan 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, we should be setting meaningful values here. The Azure documentation will probably have some information on what the values of these should be.

Copy link
Contributor Author

@mkohn mkohn Jan 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stephybun They are not set to arbitrary maximum value. They are set to 128TB see https://learn.microsoft.com/en-us/azure/azure-sql/database/resource-limits-vcore-single-databases?view=azuresql#hyperscale---provisioned-compute---gen5 for more details. and for the premium memory optimized https://learn.microsoft.com/en-us/azure/azure-sql/database/resource-limits-vcore-single-databases?view=azuresql#hyperscale-premium-series-part-1-of-3

},
},
}
Expand All @@ -251,6 +269,8 @@ var getTierFromName = map[string]string{
"bc_gen5": "BusinessCritical",
"bc_dc": "BusinessCritical",
"hs_gen5": "HyperScale",
"hs_prms": "HyperScale",
"hs_moprms": "HyperScale",
}

func MSSQLElasticPoolValidateSKU(diff *pluginsdk.ResourceDiff) error {
Expand Down
Loading