Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_container_app(_job) - Remove termination_grace_period_seconds attribute from probes #28622

Merged
merged 3 commits into from
Jan 30, 2025

Conversation

sreallymatt
Copy link
Collaborator

@sreallymatt sreallymatt commented Jan 29, 2025

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Remove termination_grace_period_seconds attribute from liveness_probe and startup_probe as the API does not currently return this property.

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_resource - support for the thing1 property [GH-00000]

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #28470

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@sreallymatt sreallymatt requested a review from a team as a code owner January 29, 2025 03:44
@sreallymatt sreallymatt changed the title azurerm_container_app(_job) - Remove 'termination_grace_period_seconds' attribute from probes azurerm_container_app(_job) - Remove termination_grace_period_seconds attribute from probes Jan 29, 2025
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the 5.0 upgrade guide with these changes as well?

Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sreallymatt - LGTM 👍

@sreallymatt sreallymatt merged commit 5168243 into main Jan 30, 2025
34 checks passed
@sreallymatt sreallymatt deleted the mp/container-app-remove-attr branch January 30, 2025 15:35
@github-actions github-actions bot added this to the v4.17.0 milestone Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants