Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

containerapps - fix breaking schema behavioural change #28639

Merged

Conversation

jackofallops
Copy link
Member

depends on #28625

stephybun
stephybun previously approved these changes Jan 30, 2025
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jackofallops LGTM 🦎

@jackofallops
Copy link
Member Author

Test passing, 2 transient failures unrelated to change:

image

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jackofallops 🌵

@jackofallops jackofallops merged commit 083f474 into main Jan 30, 2025
34 checks passed
@jackofallops jackofallops deleted the b/resolve-breaking-behavioural-change-container-app-env branch January 30, 2025 15:08
@github-actions github-actions bot added this to the v4.17.0 milestone Jan 30, 2025
hqhqhqhqhqhqhqhqhqhqhq pushed a commit to hqhqhqhqhqhqhqhqhqhqhq/terraform-provider-azurerm that referenced this pull request Feb 26, 2025
…8639)

* fixup breaking behavioural change

* fixup CustomizeDiff for computed value

* add 5.0 feature flagging

* update locations for testing as northcentralus does not support availability zones

* remove unnecessary schema description entry

* Apply suggestions from code review

Co-authored-by: stephybun <[email protected]>

* Update 5.0-upgrade-guide

* expand deprecation description to cover default behaviour

---------

Co-authored-by: stephybun <[email protected]>
Copy link

github-actions bot commented Mar 2, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants