azurerm_storage_table - Support storage_account_id

[magodo]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

This PR introduces the storage_account_id to supersede the storage_account_name property into azurerm_storage_table. This allows the provider to create and manage the resource via the Resource Manager API rather than the Data Plane.
Existing resources using the storage_account_name property cannot be migrated directly, but can be removed and re-imported using the Resource Manager ID type.

The storage_account_name property is now deprecated and will be removed in v5.0 of the provider.

The resource_manager_id property is now deprecated and will be removed in v5.0 of the provider, this value is available as id in resources using storage_account_id.

NOTE: The time format of start, expiry under acl needs to be tuned to avoid breaking changes. See the code comment for details.

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevant documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

$ TF_ACC=1 go test -v -timeout=20h -parallel=20 -run='TestAccDataSourceStorageTable_' ./internal/services/storage
=== RUN   TestAccDataSourceStorageTable_basic
=== PAUSE TestAccDataSourceStorageTable_basic
=== RUN   TestAccDataSourceStorageTable_basicDeprecated
=== PAUSE TestAccDataSourceStorageTable_basicDeprecated
=== CONT  TestAccDataSourceStorageTable_basic
=== CONT  TestAccDataSourceStorageTable_basicDeprecated
--- PASS: TestAccDataSourceStorageTable_basic (144.52s)
--- PASS: TestAccDataSourceStorageTable_basicDeprecated (146.84s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/storage       146.866s

$ TF_ACC=1 go test -v -timeout=20h -parallel=20 -run='TestAccStorageTable_' ./internal/services/storage
=== RUN   TestAccStorageTable_basic
=== PAUSE TestAccStorageTable_basic
=== RUN   TestAccStorageTable_basicDeprecated
=== PAUSE TestAccStorageTable_basicDeprecated
=== RUN   TestAccStorageTable_requiresImport
=== PAUSE TestAccStorageTable_requiresImport
=== RUN   TestAccStorageTable_requiresImportDeprecated
=== PAUSE TestAccStorageTable_requiresImportDeprecated
=== RUN   TestAccStorageTable_disappears
=== PAUSE TestAccStorageTable_disappears
=== RUN   TestAccStorageTable_disappearsDeprecated
=== PAUSE TestAccStorageTable_disappearsDeprecated
=== RUN   TestAccStorageTable_acl
=== PAUSE TestAccStorageTable_acl
=== RUN   TestAccStorageTable_aclDeprecated
=== PAUSE TestAccStorageTable_aclDeprecated
=== CONT  TestAccStorageTable_basic
=== CONT  TestAccStorageTable_disappears
=== CONT  TestAccStorageTable_requiresImport
=== CONT  TestAccStorageTable_acl
=== CONT  TestAccStorageTable_basicDeprecated
=== CONT  TestAccStorageTable_disappearsDeprecated
=== CONT  TestAccStorageTable_requiresImportDeprecated
=== CONT  TestAccStorageTable_aclDeprecated
--- PASS: TestAccStorageTable_disappears (143.72s)
--- PASS: TestAccStorageTable_disappearsDeprecated (146.66s)
--- PASS: TestAccStorageTable_requiresImport (150.42s)
--- PASS: TestAccStorageTable_requiresImportDeprecated (158.28s)
--- PASS: TestAccStorageTable_basic (161.19s)
--- PASS: TestAccStorageTable_basicDeprecated (165.89s)
--- PASS: TestAccStorageTable_acl (196.53s)
--- PASS: TestAccStorageTable_aclDeprecated (212.16s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/storage       212.191s

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_storage_table - Support storage_account_id [GH-00000]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #0000

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[magodo]

There probably wants a new url attribute as the azurerm_storage_share, to be used by any downstream resources that referencing the old form of ID (the data plane URL).

For this reason, I want to use the function GetAccount() introduced in #28617 for getting the account detail to get its data plane endpoint. Appreciate someone can take a look at #28617 and get it merged, then I'll add the url attribute here.