-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_container_app
: add support for client_certificate_mode
in data source
#28793
azurerm_container_app
: add support for client_certificate_mode
in data source
#28793
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this @jiaweitao001, I've left one comment inline
@@ -282,6 +282,8 @@ An `ingress` block supports the following: | |||
|
|||
* `transport` - The transport method for the Ingress. Possible values include `auto`, `http`, and `http2`. Defaults to `auto` | |||
|
|||
* `client_certificate_mode` - The client certificate mode for the Ingress. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you move this property above custom_domain
so it's in alphabetical order?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. Will fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM!
… data source (hashicorp#28793) * azurerm_container_app: add support for client_certificate_mode in data source * address comments on docs
Community Note
Description
PR Checklist
For example: “
resource_name_here
- description of change e.g. adding propertynew_property_name_here
”Changes to existing Resource / Data Source
Testing
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_container_app
: add support forclient_certificate_mode
in data sourceThis is a (please select all that apply):
Related Issue(s)
Fixes #28800
Related to #28523
Note
If this PR changes meaningfully during the course of review please update the title and description as required.