Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding UltraSSD to list of sku names when creating a managed disk #3453

Merged
merged 1 commit into from
May 16, 2019
Merged

Adding UltraSSD to list of sku names when creating a managed disk #3453

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions azurerm/resource_arm_managed_disk.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,8 @@ func resourceArmManagedDiskCreateUpdate(d *schema.ResourceData, meta interface{}
skuName = compute.StandardLRS
} else if strings.EqualFold(storageAccountType, string(compute.StandardSSDLRS)) {
skuName = compute.StandardSSDLRS
} else if strings.EqualFold(storageAccountType, string(compute.UltraSSDLRS)) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔

Is there a reason this entire if/else block isn't just:

		skuName = string(compute.storageAccountType)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I was just mimicking the existing structure, but I am happy to change it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In talking with the team it seems like there is a reason behind this, as we are going to release later today i'm just going to merge it in as is and can revisit it at a later time

skuName = compute.UltraSSDLRS
}

createDisk := compute.Disk{
Expand Down