Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for custom resource group name in AKS #3869

Closed
wants to merge 1 commit into from

Conversation

kamil-mrzyglod
Copy link

Hi,

I wanted to use Terraform for my project, but I found one particular thing missing - lack of possibility to enter a custom name for a node resource group in Azure Kubernetes Service. To make a long story short - by default, AKS creates an additional resource group holding all the infrastructure resources and keeping them separate from the managed cluster. That RG has a dummy name what makes following naming conventions difficult. This is why Microsoft added a nodeResourceGroup parameter in the 2019-04-01 API version.

From my investigation, Terraform supports that parameter but only as an output. This PR adds support for nodeResourceGroup by introducing a custom_node_resource_group parameter. I did not use node_resource_group name as it was already added as a computed result of running an AKS deployment.

Kamil

@tombuildsstuff
Copy link
Contributor

hey @kamil-mrzyglod

Thanks for this PR :)

Taking a look through, whilst this PR looks good it appears to be a duplicate of #3785 (which is now in a position where that can be merged) - as such whilst I'd like to thank you for this contribution, I hope you don't mind but I'm going to close this PR in favour of #3785.

Thanks!

@ghost
Copy link

ghost commented Aug 18, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants