azurerm_monitor_metric_alert: Removed maxItems for the scope property
#4111
Conversation
katbyte
changed the title
scope property
katbyte
changed the title
scope propertyazurerm_monitor_metric_alert: Removed maxItems for the scope property
| "scopes": { | ||
| Type: schema.TypeSet, | ||
| Required: true, | ||
| MinItems: 1, | ||
| MaxItems: 1, | ||
| ForceNew: true, |
There was a problem hiding this comment.
we only need to recreate the resource in some occasions, is it possible to make this conditional?
There was a problem hiding this comment.
This is a breaking change? And I believe you can do this via CustomizeDiff but i'm not sure how exactly to do it.
|
@katbyte would you review again please? |
| @@ -37,16 +37,25 @@ func resourceArmMonitorMetricAlert() *schema.Resource { | |||
| ValidateFunc: validate.NoEmptyStrings, | |||
| }, | |||
|
|
|||
| "target_resource_type": { | |||
There was a problem hiding this comment.
This looks unrelated to removing the max items property? PR title might warrant updating?
| "scopes": { | ||
| Type: schema.TypeSet, | ||
| Required: true, | ||
| MinItems: 1, | ||
| MaxItems: 1, | ||
| ForceNew: true, |
There was a problem hiding this comment.
This is a breaking change? And I believe you can do this via CustomizeDiff but i'm not sure how exactly to do it.
| metricData = append(metricData, *metricCriteria) | ||
| } | ||
| } else { | ||
| metricData = *criteria.AllOf |
There was a problem hiding this comment.
I think you'll need the nil checkes here?
| @@ -70,6 +70,8 @@ The following arguments are supported: | |||
| * `name` - (Required) The name of the Metric Alert. Changing this forces a new resource to be created. | |||
| * `resource_group_name` - (Required) The name of the resource group in which to create the Metric Alert instance. | |||
| * `scopes` - (Required) The resource ID at which the metric criteria should be applied. | |||
There was a problem hiding this comment.
Could we update this to reflect multiple can now be used?
|
hey @e96wic Whilst I'd like to thank you for this contribution - since there's some outstanding comments and we've not heard back from you here, rather than leaving this PR open indefinitely I'm going to close this PR for the moment. That said if you (or someone else) is able to finish this off then we're more than happy to take another look and get this merged :) Thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Fixes #3719