Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/storage_account: configuring secure_transfer_required #5022

Closed
wants to merge 1 commit into from

Conversation

yupwei68
Copy link
Contributor

@yupwei68 yupwei68 commented Nov 29, 2019

Please refer to issue: #5010
Azure strongly suggest that enable_https_traffic_only should be enabled by default from aspect of security reasons

Fixes #5010

@ghost ghost added the size/XS label Nov 29, 2019
@yupwei68 yupwei68 closed this Nov 29, 2019
@yupwei68 yupwei68 force-pushed the wyp-storageacc-https branch from 080fd6d to 4a8ab56 Compare November 29, 2019 09:00
@tombuildsstuff
Copy link
Contributor

👋

Since this PR introduces a breaking change (and thus has to be parked until 2.0) unfortunately this PR's ended up getting into a conflict with the recent refactoring.

As such rather than trying to rebase this (and potentially have further issues whilst we're waiting to begin the deprecation/breaking changes work on 2.0) - whilst I'd like to thank you for this contribution I'm going to close this PR for the moment - however we'll re-open this fix for #5010 in the near-future once the work deprecation/breaking changes work for 2.0 has started.

Thanks!

@tombuildsstuff tombuildsstuff removed this from the v2.0.0 milestone Feb 10, 2020
@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
@yupwei68 yupwei68 deleted the wyp-storageacc-https branch March 30, 2020 01:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

r/storage_account: configuring secure_transfer_required
2 participants