r/kubernetes_cluster: renaming managed_cluster_identity to identity
#5278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y` to match other resources In other resources MSI is handled through a block named `identity` - this PR switches over to using the same naming for consistency
tombuildsstuff
force-pushed
the
r/kube-identity
branch
from
75d9d9f to
194ffa4
Compare
After testing it appears a Service Principal is still required at this time since provisioning a cluster without an SP shows the error: Code="DeployTemplateError" Message="We are unable to serve this request due to an internal error, Correlation ID: 06898b7c-bd22-7310-35d6-67b8a2aa0336, Operation ID: ec75d845-2ba2-4dd1-bc77-8a3db3e5f27c, Timestamp: 2020-01-07T15:26:58Z."
tombuildsstuff
force-pushed
the
r/kube-identity
branch
from
babf9b8 to
7ff35c2
Compare
|
Tests look good 👍 |
|
This has been released in version 1.40.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.40.0"
}
# ... other configuration ... |
ghost
mentioned this pull request
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making this consistent with the other resources, which all use
identityas the name of the MSI blockThis hasn't shipped yet - thus this isn't a breaking change