Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Issue #5227 #5461

Closed
wants to merge 2 commits into from
Closed

Fix for Issue #5227 #5461

wants to merge 2 commits into from

Conversation

phires
Copy link
Contributor

@phires phires commented Jan 21, 2020

This resolves issue #5227.

CIDR notations are now checked using the respective go function instead of a regex.
This leads to old notations without the network suffix to be invalid and could possible break some deployments.
Additionally a validation func is added for these invalid notations (CIDRAllowNoSuffix).

Also, as more and more services now allow IPv4 and IPv6 a func has been added to validate both versions (IPAddress)

@ghost ghost added the size/L label Jan 21, 2020
@katbyte
Copy link
Collaborator

katbyte commented Jan 21, 2020

Hey @phires, thank you for doing this.

We recently moved the non azure specific validators into the plugin SDK: hashicorp/terraform-plugin-sdk#296 & hashicorp/terraform-plugin-sdk#301

Is there anything here not already reflected by those PRs? - we have decided to remove the AndEmpty ones as we can no combine them with Any or All

@phires
Copy link
Contributor Author

phires commented Jan 24, 2020

Moving the validators up to the SDK is a great idea, as all providers participate of those now.
So I guess this PR can be closed, as everything seems to be there.

@ghost ghost removed the waiting-response label Jan 24, 2020
@katbyte
Copy link
Collaborator

katbyte commented Jan 24, 2020

Closing as requested 👍

@katbyte katbyte closed this Jan 24, 2020
@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants