Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected Prefix Length #5670

Merged
merged 1 commit into from
Feb 17, 2020
Merged

Corrected Prefix Length #5670

merged 1 commit into from
Feb 17, 2020

Conversation

johnwildes
Copy link
Contributor

The maximum IP prefix length that can be reserved (according to docs.microsoft) is /28 or 16 usable addresses.

https://docs.microsoft.com/en-us/azure/virtual-network/public-ip-address-prefix#constraints

The maximum IP prefix length that can be reserved (according to docs.microsoft) is `/28` or 16 usable addresses.

https://docs.microsoft.com/en-us/azure/virtual-network/public-ip-address-prefix#constraints
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doc fix looks good but we'll want to update the validation for this attribute as well. The line you'll want to change is here https://github.com/terraform-providers/terraform-provider-azurerm/blob/master/azurerm/internal/services/network/resource_arm_public_ip_prefix.go#L62

@johnwildes
Copy link
Contributor Author

@mbfrahry I updated the module, PR is here #5693

@ghost ghost removed the waiting-response label Feb 12, 2020
@mbfrahry
Copy link
Member

Thanks for that @johnwildes. Can we keep the changes to a single pr though? It helps us have a single point of reference when looking at how/why a change was made. Also rebasing with master should allow the travis tests to pass.

@johnwildes
Copy link
Contributor Author

@mbfrahry I think I understand what you're saying. I opened this PR for the documentation, and instead of updating the actual code in this PR as well, I opened a new PR. I'll remember this for the future and just submit one. I don't see a way to fix this from here.

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in conjunction with #5693 👍

@tombuildsstuff tombuildsstuff dismissed mbfrahry’s stale review February 17, 2020 12:26

dismissing since the other changes have been made in 5693

@tombuildsstuff
Copy link
Contributor

The travis failures are unrelated (and have since been fixed in master) - this LGTM 👍

@tombuildsstuff tombuildsstuff added this to the v2.0.0 milestone Feb 17, 2020
@tombuildsstuff tombuildsstuff merged commit 8631d0a into hashicorp:master Feb 17, 2020
@johnwildes johnwildes deleted the patch-2 branch February 17, 2020 17:50
@ghost
Copy link

ghost commented Feb 24, 2020

This has been released in version 2.0.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.0.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants