-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrected Prefix Length #5670
Corrected Prefix Length #5670
Conversation
The maximum IP prefix length that can be reserved (according to docs.microsoft) is `/28` or 16 usable addresses. https://docs.microsoft.com/en-us/azure/virtual-network/public-ip-address-prefix#constraints
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doc fix looks good but we'll want to update the validation for this attribute as well. The line you'll want to change is here https://github.com/terraform-providers/terraform-provider-azurerm/blob/master/azurerm/internal/services/network/resource_arm_public_ip_prefix.go#L62
Thanks for that @johnwildes. Can we keep the changes to a single pr though? It helps us have a single point of reference when looking at how/why a change was made. Also rebasing with master should allow the travis tests to pass. |
@mbfrahry I think I understand what you're saying. I opened this PR for the documentation, and instead of updating the actual code in this PR as well, I opened a new PR. I'll remember this for the future and just submit one. I don't see a way to fix this from here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in conjunction with #5693 👍
dismissing since the other changes have been made in 5693
The travis failures are unrelated (and have since been fixed in master) - this LGTM 👍 |
This has been released in version 2.0.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.0.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
The maximum IP prefix length that can be reserved (according to docs.microsoft) is
/28
or 16 usable addresses.https://docs.microsoft.com/en-us/azure/virtual-network/public-ip-address-prefix#constraints