New Resource: azurerm_network_interface_security_group_association
#5765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tombuildsstuff
added
new-resource
service/network-interfaces
new-virtual-resource
This commit introduces a new resource for linking a Network Interface and a Network Security Group which is required to work around a dependency issue in the Azure API where the NSG must be detached in order to be able to delete dependent resources.
tombuildsstuff
force-pushed
the
f/network-interface-nsg-association
branch
from
ca328ae to
05bac6e
Compare
…s removed in 2.0)
|
Tests pass:
|
...services/network/tests/network_interface_network_security_group_association_resource_test.go
Show resolved
Hide resolved
website/docs/r/network_interface_security_group_association.html.markdown
Show resolved
Hide resolved
| } | ||
|
|
||
| // first double-check it doesn't exist | ||
| resourceId := fmt.Sprintf("%s|%s", networkInterfaceId, networkSecurityGroupId) |
There was a problem hiding this comment.
The pipe separator may cause issue with terraform import ? (see comment on docs)
|
Superseded by #5784 |
|
This has been released in version 2.0.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.0.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a new resource for linking a Network Interface and a Network Security Group which is required to work around a dependency issue in the Azure API where the NSG must be detached in order to be able to delete dependent resources. By introducing a separate resource to do this we can force this in Terraform which also handily works around the issue in the Azure API.
Due to a design limitation which exists in the Azure SDK for Go <-> Azure Resource Manager API - this PR introduces an override from the Go SDK which allows us to remove the Network Security Group ID - which is required for this resource to work.
Ultimately this resource & a patch to the Application Security Group association resource may need to be backported to 1.x - will confirm on Monday.