-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_traffic_manager_profile - support for custom_header (#2187) #5923
azurerm_traffic_manager_profile - support for custom_header (#2187) #5923
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jstevans,
Thanks for the PR, in addtion to the comments i've left inline could we add set this in the complete test to make sure it works and update the docs to reflect the new property? thanks!
azurerm/internal/services/trafficmanager/resource_arm_traffic_manager_profile.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/trafficmanager/resource_arm_traffic_manager_profile.go
Show resolved
Hide resolved
@katbyte I've responded to your concerns -- would be great to get another look 🙂 Also, due to covid19 I'm unable to get to the computer that has a working |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jstevans,
I've made the required changes and this LGTM now 👍 stay safe
@katbyte You rock! 🙌 How do we go about getting this merged? |
This has been released in version 2.3.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.3.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
(fixes #2187)