Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_policy_definition- Fixed import regex when using management groups #5981

Merged

Conversation

sas-pemcne
Copy link
Contributor

There is a typo in the regex to parse the management group id out of the policy definition id during an import. This fixes the case and allows the management group id to be correctly pulled, otherwise terraform always thinks the policy definition lives at the subscription level which always results in an error.

Policy definition id structure: /providers/Microsoft.Management/managementGroups/<group id>/providers/Microsoft.Authorization/policyDefinitions/<id>

@ghost ghost added the size/XS label Mar 4, 2020
@tombuildsstuff tombuildsstuff added this to the v2.2.0 milestone Mar 16, 2020
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @sas-pemcne

@katbyte katbyte changed the title Fixed regex to for policy definition import when using management groups azurerm_policy_definition- Fixed import regex when using management groups Mar 17, 2020
@katbyte katbyte modified the milestones: v2.2.0, v2.3.0 Mar 18, 2020
@tombuildsstuff tombuildsstuff merged commit 7c66fa5 into hashicorp:master Mar 19, 2020
tombuildsstuff added a commit that referenced this pull request Mar 19, 2020
@ghost
Copy link

ghost commented Mar 27, 2020

This has been released in version 2.3.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.3.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants