New Resource azurerm_cosmosdb_sql_storedprocedure
#6189
Conversation
…-08-01/documentdb; go mod tidy; go mod vendor
jackbatzner
force-pushed
the
azurerm_cosmosdb_sqlstoredprocedure
branch
from
d14d56f to
eee4967
Compare
There was a problem hiding this comment.
hey @Brunhil
Thanks for this PR :)
Taking a look through this is looking pretty good - I've left some comments inline but if we can fix those up then this otherwise LGTM 👍
Thanks!
| @@ -2,18 +2,24 @@ package client | |||
|
|
|||
| import ( | |||
| "github.com/Azure/azure-sdk-for-go/services/cosmos-db/mgmt/2015-04-08/documentdb" | |||
| sqlResources "github.com/Azure/azure-sdk-for-go/services/cosmos-db/mgmt/2019-08-01/documentdb" | |||
There was a problem hiding this comment.
is there a reason to only do this for the SQL Resources? in general we've found it best to use the same API version for all components of a service to ensure the service behaves correctly - as such it'd be good to update all of the resources if possible
There was a problem hiding this comment.
The only reason was to reduce potential for breaking changes on other resources. I'll work on cleaning up the other comments and get this one addressed last.
Great idea for keeping all resources in sync with the latest API!
There was a problem hiding this comment.
This has been addressed in PR 6253. I will update the client in this PR when the other one gets merged in
azurerm/internal/services/cosmos/resource_arm_cosmosdb_sql_storedprocedure.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/cosmos/resource_arm_cosmosdb_sql_storedprocedure.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/cosmos/resource_arm_cosmosdb_sql_storedprocedure.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/cosmos/resource_arm_cosmosdb_sql_storedprocedure.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/cosmos/tests/resource_arm_cosmosdb_sql_storedprocedure_test.go
Outdated
Show resolved
Hide resolved
…hange to upgrade it to v40.4.0)
jackbatzner
changed the title
azurerm_cosmosdb_sql_storedprocedureazurerm_cosmosdb_sql_storedprocedure
jackbatzner
force-pushed
the
azurerm_cosmosdb_sqlstoredprocedure
branch
from
2b4ad81 to
59b3339
Compare
jackbatzner
changed the title
azurerm_cosmosdb_sql_storedprocedureazurerm_cosmosdb_sql_storedprocedure
| `, template, data.RandomInteger) | ||
| } | ||
|
|
||
| func testAccAzureRMCosmosDbSqlStoredProcedure_update(data acceptance.TestData) string { |
There was a problem hiding this comment.
This test was having issues running when updating it locally. Will continue troubleshooting the issues locally before pushing again. Wanted to get the other changes reviewed first
katbyte
added
the
sdk/requires-newer-api-version
|
blocked by #6253 |
katbyte
removed
dependencies
sdk/requires-newer-api-version
|
This has been released in version 2.30.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.30.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Add new resource
azurerm_cosmosdb_sql_storedprocedureto cover part of #5979=== RUN TestAccAzureRMCosmosDbSqlStoredProcedure_basic
=== PAUSE TestAccAzureRMCosmosDbSqlStoredProcedure_basic
=== CONT TestAccAzureRMCosmosDbSqlStoredProcedure_basic
--- PASS: TestAccAzureRMCosmosDbSqlStoredProcedure_basic (1347.06s)
=== RUN TestAccAzureRMCosmosDbSqlStoredProcedure_update
=== PAUSE TestAccAzureRMCosmosDbSqlStoredProcedure_update
=== CONT TestAccAzureRMCosmosDbSqlStoredProcedure_update
--- PASS: TestAccAzureRMCosmosDbSqlStoredProcedure_update (1704.64s)