fix: #6343 use d.GetOk to get qname_runtime_endpoint #6344
Conversation
There was a problem hiding this comment.
hey @johejo
Thanks for this PR :)
Taking a look through this is looking good - if we can add an acceptance test to confirm this works then this should otherwise be good 👍
Thanks!
| qnaRuntimeEndpoint, exists := d.GetOk("qna_runtime_endpoint") | ||
| if exists { | ||
| props.Properties.APIProperties.QnaRuntimeEndpoint = utils.String(qnaRuntimeEndpoint.(string)) | ||
| } |
There was a problem hiding this comment.
could we add an acceptance test to confirm this works when the qna_runtime_endpoint field is unset?
There was a problem hiding this comment.
OK, I will try. This is my first contribution. Is there any existing test code similar to this change I can refer to?
|
Hmm, temporarily I reverted the fix after adding the test, but the test seems to pass. I am confused. |
|
@johejo, could it be the service's API changed behaviour and fix the bug? The tests used to pass with the current code |
|
@katbyte If the bug report is wrong, close this PR. |
|
closing as requested. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
fix #6343