azurerm_eventhub_authorization_rule - Fix intermittent 404 errors
#7122
Conversation
nickmhankins
commented
May 28, 2020
•
nickmhankins
commented
- Add retry for Event Hub Authorization Rule create to prevent 404 error, since adding Locks didn't seem to do the trick (Fixes Intermittent issues when creating azurerm_eventhub_authorization_rule #6983 Terraform apply errors with 404 when creating multiple auth rules for event hubs #4893)
- Fix 404 error when deleting rules
- Update case for Namespace Authorization Rules API path to account for Azure Go SDK update (provider: upgrade azure-sdk-for-go to v42.1.0 & azuread to v0.9.0 #6725) (Fixes Error making Read request on Azure EventHub Authorization Rule #7132)
|
Looks like this failed for other reasons: |
There was a problem hiding this comment.
Hey @nickmhankins, this looks good! I just think we can be a little more specific on the RetryableError piece
| } | ||
| read, err := client.GetAuthorizationRule(ctx, resourceGroup, namespaceName, eventHubName, name) | ||
| if err != nil { | ||
| return resource.RetryableError(fmt.Errorf("Expected instance of the authorization rule %q (event Hub %q / Namespace %q / Resource Group %q) to be created but was in non existent state, retrying", name, eventHubName, namespaceName, resourceGroup)) |
There was a problem hiding this comment.
What're your thoughts on retrying only when we error on a 404? Make it a little more specific to the error we are trying to solve
There was a problem hiding this comment.
That's a great idea, i'll work on that
There was a problem hiding this comment.
@mbfrahry Requested change has been made
mbfrahry
changed the title
azurerm_eventhub_authorization_rule - Fix intermittent 404 errors
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
