Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_postgresql_server fix acctests and issues ssl_enforcement_enabled cannot be updated #7558

Closed
wants to merge 8 commits into from

Conversation

yupwei68
Copy link
Contributor

@yupwei68 yupwei68 commented Jul 2, 2020

fix #7397
#7475
#8084
#8314

Except issues, several minor issues in acctest have been fixed:

  1. In acctests, infrastructure_encryption_enabled and geo_redundant_backup cannot be updated, updating these fields has been removed.
  2. add a hasChange judgement for all deprecated fields in update, avoiding they'll not be updated too.
  3. Acctests have removed some test steps, for example, storage_mb could not be updated to downscale, create_replica and create_PITR has the same sku with the source db, etc.

tests:

=== RUN   TestAccAzureRMPostgreSQLServer_basicNinePointFive
=== PAUSE TestAccAzureRMPostgreSQLServer_basicNinePointFive
=== CONT  TestAccAzureRMPostgreSQLServer_basicNinePointFive
--- PASS: TestAccAzureRMPostgreSQLServer_basicNinePointFive (380.25s)
=== RUN   TestAccAzureRMPostgreSQLServer_basicNinePointFiveDeprecated
=== PAUSE TestAccAzureRMPostgreSQLServer_basicNinePointFiveDeprecated
=== CONT  TestAccAzureRMPostgreSQLServer_basicNinePointFiveDeprecated
--- PASS: TestAccAzureRMPostgreSQLServer_basicNinePointFiveDeprecated (328.81s)
=== RUN   TestAccAzureRMPostgreSQLServer_basicNinePointSix
=== PAUSE TestAccAzureRMPostgreSQLServer_basicNinePointSix
=== CONT  TestAccAzureRMPostgreSQLServer_basicNinePointSix
--- PASS: TestAccAzureRMPostgreSQLServer_basicNinePointSix (290.68s)
=== RUN   TestAccAzureRMPostgreSQLServer_basicTenPointZero
=== PAUSE TestAccAzureRMPostgreSQLServer_basicTenPointZero
=== CONT  TestAccAzureRMPostgreSQLServer_basicTenPointZero
--- PASS: TestAccAzureRMPostgreSQLServer_basicTenPointZero (413.03s)
=== RUN   TestAccAzureRMPostgreSQLServer_gpTenPointZero
=== PAUSE TestAccAzureRMPostgreSQLServer_gpTenPointZero
=== CONT  TestAccAzureRMPostgreSQLServer_gpTenPointZero
--- PASS: TestAccAzureRMPostgreSQLServer_gpTenPointZero (230.74s)
=== RUN   TestAccAzureRMPostgreSQLServer_moTenPointZero
=== PAUSE TestAccAzureRMPostgreSQLServer_moTenPointZero
=== CONT  TestAccAzureRMPostgreSQLServer_moTenPointZero
--- PASS: TestAccAzureRMPostgreSQLServer_moTenPointZero (233.16s)
=== RUN   TestAccAzureRMPostgreSQLServer_basicEleven
=== PAUSE TestAccAzureRMPostgreSQLServer_basicEleven
=== CONT  TestAccAzureRMPostgreSQLServer_basicEleven
--- PASS: TestAccAzureRMPostgreSQLServer_basicEleven (289.24s)
=== RUN   TestAccAzureRMPostgreSQLServer_autogrowOnly
=== PAUSE TestAccAzureRMPostgreSQLServer_autogrowOnly
=== CONT  TestAccAzureRMPostgreSQLServer_autogrowOnly
--- PASS: TestAccAzureRMPostgreSQLServer_autogrowOnly (269.48s)
=== RUN   TestAccAzureRMPostgreSQLServer_requiresImport
=== PAUSE TestAccAzureRMPostgreSQLServer_requiresImport
=== CONT  TestAccAzureRMPostgreSQLServer_requiresImport
--- PASS: TestAccAzureRMPostgreSQLServer_requiresImport (539.85s)
=== RUN   TestAccAzureRMPostgreSQLServer_complete
=== PAUSE TestAccAzureRMPostgreSQLServer_complete
=== CONT  TestAccAzureRMPostgreSQLServer_complete
--- PASS: TestAccAzureRMPostgreSQLServer_complete (241.44s)
=== RUN   TestAccAzureRMPostgreSQLServer_updatedDeprecated
=== PAUSE TestAccAzureRMPostgreSQLServer_updatedDeprecated
=== CONT  TestAccAzureRMPostgreSQLServer_updatedDeprecated
--- PASS: TestAccAzureRMPostgreSQLServer_updatedDeprecated (430.00s)
=== RUN   TestAccAzureRMPostgreSQLServer_completeDeprecatedUpdate
=== PAUSE TestAccAzureRMPostgreSQLServer_completeDeprecatedUpdate
=== CONT  TestAccAzureRMPostgreSQLServer_completeDeprecatedUpdate
--- PASS: TestAccAzureRMPostgreSQLServer_completeDeprecatedUpdate (460.20s)
=== RUN   TestAccAzureRMPostgreSQLServer_updated
=== PAUSE TestAccAzureRMPostgreSQLServer_updated
=== CONT  TestAccAzureRMPostgreSQLServer_updated
--- PASS: TestAccAzureRMPostgreSQLServer_updated (604.28s)
=== RUN   TestAccAzureRMPostgreSQLServer_updateSKU
=== PAUSE TestAccAzureRMPostgreSQLServer_updateSKU
=== CONT  TestAccAzureRMPostgreSQLServer_updateSKU
--- PASS: TestAccAzureRMPostgreSQLServer_updateSKU (631.05s)
=== RUN   TestAccAzureRMPostgreSQLServer_createReplica
=== PAUSE TestAccAzureRMPostgreSQLServer_createReplica
=== CONT  TestAccAzureRMPostgreSQLServer_createReplica
--- PASS: TestAccAzureRMPostgreSQLServer_createReplica (740.57s)
=== RUN   TestAccAzureRMPostgreSQLServer_createPointInTimeRestore
=== PAUSE TestAccAzureRMPostgreSQLServer_createPointInTimeRestore
=== CONT  TestAccAzureRMPostgreSQLServer_createPointInTimeRestore
--- PASS: TestAccAzureRMPostgreSQLServer_createPointInTimeRestore (1657.20s)

@yupwei68 yupwei68 changed the title azurerm_postgresql_server fix issues ssl_enforcement_enabled cannot be updated azurerm_postgresql_server fix acctests and issues ssl_enforcement_enabled cannot be updated Jul 9, 2020
yupwei68 added 2 commits July 10, 2020 11:37
@ghost ghost added size/L and removed size/M labels Jul 10, 2020
@yupwei68
Copy link
Contributor Author

@tombuildsstuff Thanks for comments. I have merged the changes and correspond to #6809, to deprecate the deprecated fields. Tests have been passed.
=== RUN TestAccAzureRMPostgreSQLServer_basicNinePointFive
=== PAUSE TestAccAzureRMPostgreSQLServer_basicNinePointFive
=== CONT TestAccAzureRMPostgreSQLServer_basicNinePointFive
--- PASS: TestAccAzureRMPostgreSQLServer_basicNinePointFive (292.84s)
=== RUN TestAccAzureRMPostgreSQLServer_basicNinePointFiveDeprecated
=== PAUSE TestAccAzureRMPostgreSQLServer_basicNinePointFiveDeprecated
=== CONT TestAccAzureRMPostgreSQLServer_basicNinePointFiveDeprecated
--- PASS: TestAccAzureRMPostgreSQLServer_basicNinePointFiveDeprecated (329.10s)
=== RUN TestAccAzureRMPostgreSQLServer_basicNinePointSix
=== PAUSE TestAccAzureRMPostgreSQLServer_basicNinePointSix
=== CONT TestAccAzureRMPostgreSQLServer_basicNinePointSix
--- PASS: TestAccAzureRMPostgreSQLServer_basicNinePointSix (290.90s)
=== RUN TestAccAzureRMPostgreSQLServer_basicTenPointZero
=== PAUSE TestAccAzureRMPostgreSQLServer_basicTenPointZero
=== CONT TestAccAzureRMPostgreSQLServer_basicTenPointZero
--- PASS: TestAccAzureRMPostgreSQLServer_basicTenPointZero (351.11s)
=== RUN TestAccAzureRMPostgreSQLServer_gpTenPointZero
=== PAUSE TestAccAzureRMPostgreSQLServer_gpTenPointZero
=== CONT TestAccAzureRMPostgreSQLServer_gpTenPointZero
--- PASS: TestAccAzureRMPostgreSQLServer_gpTenPointZero (244.47s)
=== RUN TestAccAzureRMPostgreSQLServer_moTenPointZero
=== PAUSE TestAccAzureRMPostgreSQLServer_moTenPointZero
=== CONT TestAccAzureRMPostgreSQLServer_moTenPointZero
--- PASS: TestAccAzureRMPostgreSQLServer_moTenPointZero (236.17s)
=== RUN TestAccAzureRMPostgreSQLServer_basicEleven
=== PAUSE TestAccAzureRMPostgreSQLServer_basicEleven
=== CONT TestAccAzureRMPostgreSQLServer_basicEleven
--- PASS: TestAccAzureRMPostgreSQLServer_basicEleven (407.58s)
=== RUN TestAccAzureRMPostgreSQLServer_autogrowOnly
=== PAUSE TestAccAzureRMPostgreSQLServer_autogrowOnly
=== CONT TestAccAzureRMPostgreSQLServer_autogrowOnly
--- PASS: TestAccAzureRMPostgreSQLServer_autogrowOnly (338.13s)
=== RUN TestAccAzureRMPostgreSQLServer_requiresImport
=== PAUSE TestAccAzureRMPostgreSQLServer_requiresImport
=== CONT TestAccAzureRMPostgreSQLServer_requiresImport
--- PASS: TestAccAzureRMPostgreSQLServer_requiresImport (358.95s)
=== RUN TestAccAzureRMPostgreSQLServer_complete
=== PAUSE TestAccAzureRMPostgreSQLServer_complete
=== CONT TestAccAzureRMPostgreSQLServer_complete
--- PASS: TestAccAzureRMPostgreSQLServer_complete (177.42s)
=== RUN TestAccAzureRMPostgreSQLServer_updatedDeprecated
=== PAUSE TestAccAzureRMPostgreSQLServer_updatedDeprecated
=== CONT TestAccAzureRMPostgreSQLServer_updatedDeprecated
--- PASS: TestAccAzureRMPostgreSQLServer_updatedDeprecated (436.11s)
=== RUN TestAccAzureRMPostgreSQLServer_completeDeprecatedUpdate
=== PAUSE TestAccAzureRMPostgreSQLServer_completeDeprecatedUpdate
=== CONT TestAccAzureRMPostgreSQLServer_completeDeprecatedUpdate
--- PASS: TestAccAzureRMPostgreSQLServer_completeDeprecatedUpdate (391.20s)
=== RUN TestAccAzureRMPostgreSQLServer_updated
=== PAUSE TestAccAzureRMPostgreSQLServer_updated
=== CONT TestAccAzureRMPostgreSQLServer_updated
--- PASS: TestAccAzureRMPostgreSQLServer_updated (713.02s)
=== RUN TestAccAzureRMPostgreSQLServer_updateSKU
=== PAUSE TestAccAzureRMPostgreSQLServer_updateSKU
=== CONT TestAccAzureRMPostgreSQLServer_updateSKU
--- PASS: TestAccAzureRMPostgreSQLServer_updateSKU (631.05s)
=== RUN TestAccAzureRMPostgreSQLServer_createReplica
=== PAUSE TestAccAzureRMPostgreSQLServer_createReplica
=== CONT TestAccAzureRMPostgreSQLServer_createReplica
--- PASS: TestAccAzureRMPostgreSQLServer_createReplica (710.24s)
=== RUN TestAccAzureRMPostgreSQLServer_createPointInTimeRestore
=== PAUSE TestAccAzureRMPostgreSQLServer_createPointInTimeRestore
=== CONT TestAccAzureRMPostgreSQLServer_createPointInTimeRestore
--- PASS: TestAccAzureRMPostgreSQLServer_createPointInTimeRestore (1532.16s)

@yupwei68 yupwei68 closed this Jul 10, 2020
@yupwei68 yupwei68 reopened this Jul 10, 2020
@yupwei68 yupwei68 closed this Sep 7, 2020
@yupwei68 yupwei68 reopened this Sep 7, 2020
@tombuildsstuff tombuildsstuff added this to the v3.0.0 milestone Oct 21, 2020
@katbyte
Copy link
Collaborator

katbyte commented Oct 22, 2020

Hey, as this is a breaking change that should wait till 3.0 i am going to close this and we can then reopen it for 3.0.

@katbyte katbyte closed this Oct 22, 2020
@ghost
Copy link

ghost commented Nov 22, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_postgresql_server: cannot update ssl_enforcement_enabled after server creation
3 participants