-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_storage_account
- support static_website
for BlockBlobStorage
account type
#7890
Conversation
Hi @magodo any chance of a code review on this PR? |
Hey @DavidSimner Thank you for this PR! It almost LGTM 👍 |
@magodo are you happy to add a test and update the docs, or would you like me to? If me, then could you please give me a few pointers to where the relevant tests and docs are? Thanks :) |
Hi @DavidSimner You might want to add a test case to test against Otherwise, I can also do the change for you if you don't mind to check the box to allow edits from maintainer. |
If you can make the change then that would great! I've given you access I think :) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
azurerm_storage_account
- Support static_website
for BlockBlobStorage
account type
@DavidSimner I have made a commit on top of your branch to add the test and document. It LGTM now! |
azurerm_storage_account
- Support static_website
for BlockBlobStorage
account typeazurerm_storage_account
- support static_website
for BlockBlobStorage
account type
This has been released in version 2.23.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.23.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Microsoft Azure supports
static_website
forBlockBlobStorage
and so this PR adds support for this intoterraform-provider-azurerm