Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_logic_app_integration_account azurerm_logic_app_workflow add support for Integration Service Environment ID property #8315

Closed
wants to merge 8 commits into from

Conversation

jackofallops
Copy link
Member

Fixes #8229

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but I'm seeing an issue when running the test. It took about 4 hours so it may be transient.

TestAccAzureRMLogicAppIntegrationAccount_completeWithISE: testing.go:684: Step 0 error: errors during apply:
Error: creating Integration Account "acctest-IA-200901193728387986" (Resource Group "acctestRG-logic-200901193728387986"): logic.IntegrationAccountsClient#CreateOrUpdate: Failure responding to request: StatusCode=400 -- Original Error: autorest/azure: Service returned an error. Status=400 Code="InvalidRequestContent" Message="The integration service environment reference Id '<null>' is not valid."

Did you see this while you were testing?

@jackofallops
Copy link
Member Author

This looks good but I'm seeing an issue when running the test. It took about 4 hours so it may be transient.

TestAccAzureRMLogicAppIntegrationAccount_completeWithISE: testing.go:684: Step 0 error: errors during apply:
Error: creating Integration Account "acctest-IA-200901193728387986" (Resource Group "acctestRG-logic-200901193728387986"): logic.IntegrationAccountsClient#CreateOrUpdate: Failure responding to request: StatusCode=400 -- Original Error: autorest/azure: Service returned an error. Status=400 Code="InvalidRequestContent" Message="The integration service environment reference Id '<null>' is not valid."

Did you see this while you were testing?

Thanks @mbfrahry - I did not, I will investigate before taking it any further. (as you noticed, testing takes... a while... )

@jackofallops jackofallops modified the milestones: v2.26.0, Blocked Sep 3, 2020
@ghost ghost added size/L and removed size/M labels Sep 3, 2020
@jackofallops jackofallops changed the title azurerm_logic_app_integration_account [Resource|Data Souce] add support for Integration Service Environment ID azurerm_logic_app_integration_account azurerm_logic_app_workflow add support for Integration Service Environment ID property Sep 3, 2020
@jackofallops
Copy link
Member Author

Apparent bug in the SDK blocking azurerm_logic_app_integration_account:
Azure/azure-rest-api-specs#10725

Will look to split out the azurerm_logic_app_workflow changes in another PR.

@jackofallops jackofallops added upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR and removed waiting-response labels Sep 8, 2020
@tombuildsstuff
Copy link
Contributor

Temporarily closing this whilst this is blocked on Azure/azure-rest-api-specs#10725 - once that's fixed we can take another look here

katbyte pushed a commit that referenced this pull request Sep 25, 2020
…ent_id (#8504)

Separate work done by @jackofallops on #8315 to unblock workflow ISE
property, while integration account is waiting on upstream fix.
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation enhancement hashibot/ignore service/logic size/L upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logic Apps - Integration Account
3 participants