Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

match_values not required when the operator is any #9560

Closed
wants to merge 2 commits into from

Conversation

uolter
Copy link
Contributor

@uolter uolter commented Nov 30, 2020

No description provided.

@ghost ghost added the size/XS label Nov 30, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @uolter, could we update the documentation for this and add a check to error out if match value is missing when required?

thanks!

@uolter
Copy link
Contributor Author

uolter commented Dec 1, 2020

Thanks for the PR @uolter, could we update the documentation for this and add a check to error out if match value is missing when required?

thanks!

Yes, sure! Unfortunately I do not have a deep knowledge with the provider. However in many cases the match_values attribute is not required when the operator is cdn.*Any, while is required with different operator vaules.
I "fixed" just the one useful to me, but some other match_values need to be fixed and a better validation to be introduces.
Thank you,
Walter (@uolter)

@katbyte
Copy link
Collaborator

katbyte commented Dec 31, 2020

Hey @uolter - this is included in #8850 which i will hopefully merge for the next release, as such i'm going to close this. THanks again for the PR!

@katbyte katbyte closed this Dec 31, 2020
@uolter
Copy link
Contributor Author

uolter commented Jan 4, 2021

Hey @uolter - this is included in #8850 which i will hopefully merge for the next release, as such i'm going to close this. THanks again for the PR!

Yep, thanks a lot!

@ghost ghost removed the waiting-response label Jan 4, 2021
@ghost
Copy link

ghost commented Jan 30, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants