Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_sentinel_alert_rule_scheduled - support alert_rule_template_guid #9712

Merged
merged 8 commits into from
Dec 27, 2020

Conversation

neil-yechenwei
Copy link
Contributor

@neil-yechenwei neil-yechenwei commented Dec 7, 2020

fixes #9715

API Spec: https://github.com/Azure/azure-sdk-for-go/blob/c760106e3c564f57cd7d264c872bc5ef324c592f/services/preview/securityinsight/mgmt/2019-01-01-preview/securityinsight/models.go#L12157

--- PASS: TestAccAzureRMSentinelAlertRuleScheduled_basic (139.73s)
--- PASS: TestAccAzureRMSentinelAlertRuleScheduled_requiresImport (149.42s)
--- PASS: TestAccAzureRMSentinelAlertRuleScheduled_complete (282.78s)
--- PASS: TestAccAzureRMSentinelAlertRuleScheduled_withAlertRuleTemplateName (314.71s)
--- PASS: TestAccAzureRMSentinelAlertRuleScheduled_update (346.63s)

@tombuildsstuff
Copy link
Contributor

@neil-yechenwei what's the use-case adding this field is looking to solve? is there a Github issue for this?

@ghost ghost added size/M and removed size/S labels Dec 7, 2020
@neil-yechenwei
Copy link
Contributor Author

@tombuildsstuff , this is the github issue link #9715

@ghost ghost removed the waiting-response label Dec 7, 2020
@ghost ghost added size/S and removed size/M labels Dec 14, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @neil-yechenwei - this LGMT 👍

@katbyte katbyte added this to the v2.42.0 milestone Dec 27, 2020
@katbyte katbyte changed the title Add new property AlertRuleTemplateName for azurerm_sentinel_alert_rule_scheduled azurerm_sentinel_alert_rule_scheduled - support alert_rule_template_guid Dec 27, 2020
@katbyte katbyte merged commit 7b8879f into hashicorp:master Dec 27, 2020
katbyte added a commit that referenced this pull request Dec 27, 2020
@ghost
Copy link

ghost commented Jan 8, 2021

This has been released in version 2.42.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.42.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jan 27, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants