Skip to content

Commit

Permalink
Add a test for using 'address' rather than 'network_ip' for instance …
Browse files Browse the repository at this point in the history
…templates
  • Loading branch information
Nic Cope committed Oct 27, 2017
1 parent 5810747 commit 4e989c1
Showing 1 changed file with 57 additions and 0 deletions.
57 changes: 57 additions & 0 deletions google/resource_compute_instance_template_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,30 @@ func TestAccComputeInstanceTemplate_networkIP(t *testing.T) {
},
})
}
func TestAccComputeInstanceTemplate_address(t *testing.T) {
t.Parallel()

var instanceTemplate compute.InstanceTemplate
address := "10.128.0.2"

resource.Test(t, resource.TestCase{
PreCheck: func() { testAccPreCheck(t) },
Providers: testAccProviders,
CheckDestroy: testAccCheckComputeInstanceTemplateDestroy,
Steps: []resource.TestStep{
resource.TestStep{
Config: testAccComputeInstanceTemplate_address(address),
Check: resource.ComposeTestCheckFunc(
testAccCheckComputeInstanceTemplateExists(
"google_compute_instance_template.foobar", &instanceTemplate),
testAccCheckComputeInstanceTemplateNetwork(&instanceTemplate),
testAccCheckComputeInstanceTemplateAddress(
"google_compute_instance_template.foobar", address, &instanceTemplate),
),
},
},
})
}

func TestAccComputeInstanceTemplate_disks(t *testing.T) {
t.Parallel()
Expand Down Expand Up @@ -494,6 +518,17 @@ func testAccCheckComputeInstanceTemplateNetworkIP(n, networkIP string, instanceT
}
}

func testAccCheckComputeInstanceTemplateAddress(n, address string, instanceTemplate *compute.InstanceTemplate) resource.TestCheckFunc {
return func(s *terraform.State) error {
ip := instanceTemplate.Properties.NetworkInterfaces[0].NetworkIP
err := resource.TestCheckResourceAttr(n, "network_interface.0.network_ip", ip)(s)
if err != nil {
return err
}
return resource.TestCheckResourceAttr(n, "network_interface.0.network_ip", address)(s)
}
}

func testAccCheckComputeInstanceTemplateContainsLabel(instanceTemplate *compute.InstanceTemplate, key string, value string) resource.TestCheckFunc {
return func(s *terraform.State) error {
v, ok := instanceTemplate.Properties.Labels[key]
Expand Down Expand Up @@ -653,6 +688,28 @@ resource "google_compute_instance_template" "foobar" {
}`, acctest.RandString(10), networkIP)
}

func testAccComputeInstanceTemplate_address(address string) string {
return fmt.Sprintf(`
resource "google_compute_instance_template" "foobar" {
name = "instancet-test-%s"
machine_type = "n1-standard-1"
tags = ["foo", "bar"]
disk {
source_image = "debian-8-jessie-v20160803"
}
network_interface {
network = "default"
address = "%s"
}
metadata {
foo = "bar"
}
}`, acctest.RandString(10), address)
}

var testAccComputeInstanceTemplate_disks = fmt.Sprintf(`
resource "google_compute_disk" "foobar" {
name = "instancet-test-%s"
Expand Down

0 comments on commit 4e989c1

Please sign in to comment.