Add Google Spanner Support (google_spanner_database)

[nickithewatt]

This PR aims to addresses #67 which looks to add Google Spanner Support, specifically adding a new resource google_spanner_database. CC @rileykarson @danawillow

In order to make these PR's easier to digest and review, instead of creating one big PR with all Spanner support in it, I have created one for each new resource to be added. This is the 2nd which adds support for the google_spanner_database resource. A separate one (PR #270) added the foundational support for creating the Instance, i.e. the google_spanner_instance resource.

This PR does build off PR #270 as it uses the the google_spanner_instance resource so that should probably be reviewed first, then this one. Alternatively if you want to review all the Spanner support, this PR will have that.

[rosbo]

Hi again Nicki.

Thanks a lot for your contribution.

Just a few comments. Very good overall.

[rosbo]

There is an update method for this. If you decide not to implement it in this PR, please file an issue and add a TODO here link to the issue.

[nickithewatt]

I am not sure an update makes sense here? My understanding is that the DDL update here is more additive style statements to apply to the database, rather than the definitive list of statements, i.e. could include update statements as well. Without support for clauses like DROP IF EXISTS, this could be quite hard to make idempotent.

Moving from this:

resource "google_spanner_database" "db1" {
  instance = "${google_spanner_instance.instance1.name}"
  name     = "mydb1"

  ddl           =  [
    "CREATE TABLE t1 (t1 INT64 NOT NULL,) PRIMARY KEY(t1)",
    "CREATE TABLE t2 (t2 INT64 NOT NULL,) PRIMARY KEY(t2)"]
}

to this:

resource "google_spanner_database" "db1" {
  instance = "${google_spanner_instance.instance1.name}"
  name     = "mydb1"

  ddl           =  [
    "CREATE TABLE t1 (t1 INT64 NOT NULL,) PRIMARY KEY(t1)",
    "CREATE TABLE t2 (t2 INT64 NOT NULL,) PRIMARY KEY(t2)",
    "CREATE TABLE t3 (t3 INT64 NOT NULL,) PRIMARY KEY(t3)"]
}

Would fail with an Error code 3 Duplicate name in schema: t1

[rosbo]

You are right. We should leave the ForceNew.

[rosbo]

No need to set the id here, it is set either in the create method or the import method.

[rosbo]

Add the computed state field here once you added it.

[rosbo]

Please, add the Computed state field.

[nickithewatt]

@rosbo Thanks again for review. Have made one comment re DDL update (see above). Rebased off the spanner-support-instance branch and made other changes as requested. Let me know if there is anything else that needs doing on this :)

[rosbo]

Thanks again for adding Spanner support

[rosbo]

make testacc TESTARGS="-run TestAccSpannerDatabase_" TEST="./google"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./google -v -run TestAccSpannerDatabase_ -timeout 120m
=== RUN TestAccSpannerDatabase_importInstanceDatabase
--- PASS: TestAccSpannerDatabase_importInstanceDatabase (24.50s)
=== RUN TestAccSpannerDatabase_importProjectInstanceDatabase
--- PASS: TestAccSpannerDatabase_importProjectInstanceDatabase (24.20s)
=== RUN TestAccSpannerDatabase_basic
--- PASS: TestAccSpannerDatabase_basic (24.00s)
=== RUN TestAccSpannerDatabase_basicWithInitialDDL
--- PASS: TestAccSpannerDatabase_basicWithInitialDDL (24.17s)
=== RUN TestAccSpannerDatabase_duplicateNameError
--- PASS: TestAccSpannerDatabase_duplicateNameError (24.31s)
PASS
ok github.com/terraform-providers/terraform-provider-google/google 121.315s

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!