Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate boot disk initialize params #592

Merged

Conversation

danawillow
Copy link
Contributor

Even though initialize params don't matter after creation, if the config is being used for repeatable deployments then users want to be able to keep them in their configs.

Fixes #581
Fixes #555

@paddycarver
Copy link
Contributor

paddycarver commented Oct 19, 2017

Should we be doing this for:

  • attached_disk?
  • scratch_disk?

@danawillow
Copy link
Contributor Author

No, neither attached_disk nor scratch_disk have initialize_params.

@danawillow danawillow merged commit 081e675 into hashicorp:master Oct 20, 2017
@danawillow danawillow deleted the maybe-the-last-migration-fix-lol branch October 20, 2017 16:45
luis-silva pushed a commit to luis-silva/terraform-provider-google that referenced this pull request May 21, 2019
…hicorp#592)

<!-- This change is generated by MagicModules. -->
Original Author: @drebes
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

disk->boot_disk initialize_params not migrated for created instances. Error in disk migration
2 participants