Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set.value: required -> optional #1572

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

set.value: required -> optional #1572

wants to merge 6 commits into from

Conversation

BBBmau
Copy link
Contributor

@BBBmau BBBmau commented Jan 25, 2025

Description

Fixes #1570

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
󰀵 mau  …/terraform-provider-helm   set-value-optional $!?   v1.23.4   21:01  
 TESTARGS="-run TestAccResourceRelease_SetNull" make testacc
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test "./helm" -v -run TestAccResourceRelease_SetNull -timeout 10m
2025/01/24 21:01:54 Created repository package for "broken-chart"
2025/01/24 21:01:54 Created repository package for "crds-chart"
2025/01/24 21:01:54 Created repository package for "dependency-bar"
2025/01/24 21:01:54 Created repository package for "dependency-foo"
2025/01/24 21:01:54 Created repository package for "failed-deploy"
2025/01/24 21:01:54 Created repository package for "kube-version"
2025/01/24 21:01:54 Created repository package for "test-chart"
2025/01/24 21:01:54 Created repository package for "test-chart-v2"
2025/01/24 21:01:54 Created repository package for "umbrella-chart"
2025/01/24 21:01:54 Built chart repository index
=== RUN   TestAccResourceRelease_SetNull
--- PASS: TestAccResourceRelease_SetNull (7.41s)
PASS
ok      github.com/hashicorp/terraform-provider-helm/helm       8.831s

image

We aren't able to have the value be null due to the following error occurring:

image

Release Note

Release note for CHANGELOG:

change `set.value` && `set_list.value` to optional instead of required

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@BBBmau BBBmau changed the title required -> optional set.value: optional -> required Jan 25, 2025
@BBBmau BBBmau changed the title set.value: optional -> required set.value: required -> optional Jan 25, 2025
@BBBmau BBBmau marked this pull request as ready for review January 25, 2025 06:04
@BBBmau BBBmau requested a review from a team as a code owner January 25, 2025 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

helm_release fails when setting fields to null (3.0.0-pre1)
1 participant