Do not remove server side fields for datasources

It does not make sense to delete server side fields for datasources, the user should be responsible for not creating loops which would cause a perpetual diff. This allows reading the status field for the generic `kubernetes_resource` datasource. Thus this PR Fixes #1699 Signed-off-by: Julien DOCHE <[email protected]>
hashicorp · Aug 9, 2022 · 31caf7a · 31caf7a
1 parent c370d92
commit 31caf7a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/manifest/provider/datasource.go b/manifest/provider/datasource.go
@@ -148,8 +148,7 @@ func (s *RawProviderServer) ReadDataSource(ctx context.Context, req *tfprotov5.R
 		return resp, nil
 	}
 
-	fo := RemoveServerSideFields(res.Object)
-	nobj, err := payload.ToTFValue(fo, objectType, th, tftypes.NewAttributePath())
+	nobj, err := payload.ToTFValue(res.Object, objectType, th, tftypes.NewAttributePath())
 	if err != nil {
 		resp.Diagnostics = append(resp.Diagnostics, &tfprotov5.Diagnostic{
 			Severity: tfprotov5.DiagnosticSeverityError,

diff --git a/manifest/test/acceptance/datasource_test.go b/manifest/test/acceptance/datasource_test.go
@@ -78,6 +78,8 @@ func TestDataSourceKubernetesResource_ConfigMap(t *testing.T) {
 	tfstate.AssertAttributeValues(t, tfstatehelper.AttributeValues{
 		"data.kubernetes_resource.test_config.object.data.TEST": "hello world",
 	})
+	// check that the data source has the status field defined
+	tfstate.AssertAttributeNotEmpty(t, "data.kubernetes_resource.test_config.object.status")
 	// check the resource was created with the correct value
 	tfstate.AssertAttributeValues(t, tfstatehelper.AttributeValues{
 		"kubernetes_manifest.test_config2.object.data.TEST": "hello world",