Add runtime_class_name to pod

[kylecarbs]

Signed-off-by: Kyle Carberry [email protected]

Description

This adds runtime_class_name to the kubernetes_pod resource.

Acceptance tests

It wasn't clear how we'd add an acceptance test for a custom runtime class without customizing the nodes. Maybe gvisor exists on the target nodes? In that case, I'll happily add a test.

Release Note

Release note for CHANGELOG:

ENHANCEMENT:
- Add "runtime_class_name" attribute to kubernetes_pod

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

[arybolovlev]

Hi @kylecarbs,

Thank you for your contribution. I will review your PR this week. A few quick notes for now:

• Can you please update all related documentation pages with this change? You can find them in the website/docs directory.
• Please add tests for the attribute you have added.

Thanks!

[arybolovlev]

Hi @kylecarbs,

Thank you for updating the pod documentation and adding validation!

As you can see, I have added a test for this new attribute. The idea is the following:

• Create a new RuntimeClass object in the Kubernetes cluster with runc handler before executing a test;
• Execute test for a new attribute and pass the RuntimeClass name from the previous step;
• Clean up the RuntimeClass.

This test works in kind and GKE clusters. I couldn't make it work in EKS, so we skip it.

Can you please also update r/pod_v1.html.markdown, r/daemonset.html.markdown, r/daemon_set_v1.html.markdown, r/deployment.html.markdown, r/deployment_v1.html.markdown, d/pod.html.markdown and d/pod_v1.html.markdown(last two files are for data source) with the same line?

P.S.: added a changelog file.

Thank you.

[kylecarbs]

@arybolovlev done! Thank you for adding the tests, I appreciate it.

[arybolovlev]

Thank you for you contribution, @kylecarbs!🚀 Great job! 😊👍🏻

[arybolovlev]

Approved! 😊 This change will be available in the upcoming release. Please keep an eye on the release notes.

Thank you, @kylecarbs!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.