-
Notifications
You must be signed in to change notification settings - Fork 988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supported Succeeded
and Failed
states in Target Pods
#2141
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One tiny request to add a description to the schema.
Please add a change log file, it is necessary here since it is a new attribute and we would want to reflect it in the release notes.
Can we add a test here or it is not necessary?
Thanks!
Type: schema.TypeBool, | ||
Optional: true, | ||
Default: true, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a description here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
Description
Adds
updated_target
attribute flag to allow users the option to use the new target fields or not. This is more to prevent any sudden breaks from this change to users.Acceptance tests
Output from acceptance testing:
Release Note
Release note for CHANGELOG:
References
Fix: #599
Community Note