Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supported Succeeded and Failed states in Target Pods #2141

Merged
merged 5 commits into from
Jul 14, 2023
Merged

Conversation

BBBmau
Copy link
Contributor

@BBBmau BBBmau commented Jun 13, 2023

Description

Adds updated_target attribute flag to allow users the option to use the new target fields or not. This is more to prevent any sudden breaks from this change to users.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Release Note

Release note for CHANGELOG:

kubernetes/resource_kubernetes_pod.go`: Add `legacy_lifecycle_states` attribute

References

Fix: #599

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@BBBmau BBBmau requested a review from a team as a code owner June 13, 2023 16:07
Copy link
Contributor

@arybolovlev arybolovlev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny request to add a description to the schema.

Please add a change log file, it is necessary here since it is a new attribute and we would want to reflect it in the release notes.

Can we add a test here or it is not necessary?

Thanks!

Type: schema.TypeBool,
Optional: true,
Default: true,
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a description here.

Copy link
Contributor

@arybolovlev arybolovlev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@BBBmau BBBmau merged commit 98b02ed into main Jul 14, 2023
@BBBmau BBBmau deleted the update-target-pods branch July 14, 2023 14:11
@BBBmau BBBmau mentioned this pull request Jul 14, 2023
2 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unexpected state 'Succeeded', wanted target 'Running'. last error: %!s(<nil>)
3 participants