Add resource and data sources for private registry GPG keys #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonc
force-pushed
the
registry-gpg-keys
branch
from
087c92a to
d53886b
Compare
tmatilai
reviewed
Dec 7, 2023
Manages a public key of the GPG key pair used to sign releases of private providers in the private registry.
Retrieves a private registry GPG key.
Retrieves all private registry GPG keys of an organization.
brandonc
force-pushed
the
registry-gpg-keys
branch
from
d73efc9 to
66550ac
Compare
nfagerlund
requested changes
Dec 7, 2023
There was a problem hiding this comment.
Looks good! Sweet to have the other shoe drop for a modern plan-modifier version of that default org adjustment.
I have not smoke-tested this, since it'll take quite some time to get my registry and stuff into a usable state, so my review is based on my reading of the code (especially your addendum commits).
One request, other than that this is 👍🏼
nfagerlund
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local branch of #1160 for CI