Add AllowMemberTokenManagement to Team #1398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliannatetreault
force-pushed
the
juliannatetreault/TF-16200-add-team-token-management
branch
from
8fc2be5 to
adea392
Compare
juliannatetreault
force-pushed
the
juliannatetreault/TF-16200-add-team-token-management
branch
from
05426e8 to
6bcb772
Compare
|
This looks good to me. Will just need a rebase once the go-tfe changes are available |
juliannatetreault
force-pushed
the
juliannatetreault/TF-16200-add-team-token-management
branch
from
96e4a05 to
6c1977f
Compare
brandonc
reviewed
Jul 30, 2024
juliannatetreault
force-pushed
the
juliannatetreault/TF-16200-add-team-token-management
branch
from
3796424 to
2e88a8c
Compare
juliannatetreault
force-pushed
the
juliannatetreault/TF-16200-add-team-token-management
branch
2 times, most recently
from
d6a8aef to
6d7dc87
Compare
juliannatetreault
force-pushed
the
juliannatetreault/TF-16200-add-team-token-management
branch
from
b4206a6 to
e71be87
Compare
emlanctot
approved these changes
Aug 7, 2024
juliannatetreault
force-pushed
the
juliannatetreault/TF-16200-add-team-token-management
branch
from
0566520 to
db5fade
Compare
brandonc
deleted the
juliannatetreault/TF-16200-add-team-token-management
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new team permission -
AllowMemberTokenManagement- to theTeamblock.AllowMemberTokenManagementistrueby default and can only be managed by Owners or users with "Manage Teams" permissions. Additionally, this PR adds tests and documentation for the new permission.Remember to:
Testing plan
allow_member_token_managementshould default totruefor new teams.allow_member_token_managementis omitted, it should default totrue.allow_member_token_managementshould be able to be set or unset via the provider.External links
Output from acceptance tests