Add support for Terraform Cloud Agents #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lafentres
reviewed
Nov 17, 2020
lafentres
reviewed
Nov 18, 2020
chrisarcand
force-pushed
the
tfc-agents-rebased
branch
7 times, most recently
from
7fb1efe to
c54bb28
Compare
Agent pools do not have a full resource lifecycle yet, so an associated resource here in the provider is not supported - yet. This has the interesting side effect of needing to create an agent pool out-of-band of the provider, temporarily. This datasource is being added now, however, to be able to configure a workspace to use an organization's single pool.
And utilize it in the data source tests, as well.
And some tests to go with all this.
…tion_mode and agent_pool_id attributes
'operations' can't be set at all, not just 'true'.
This allows importing by solely an ID to work properly.
chrisarcand
force-pushed
the
tfc-agents-rebased
branch
from
c54bb28 to
354c4d4
Compare
lafentres
reviewed
Nov 20, 2020
lafentres
approved these changes
Nov 20, 2020
There was a problem hiding this comment.
i ran this through several different test scenarios and it all looks good to me (aside from that small note about validating execution mode).
i did get some warnings locally about needing to run go mod vendor when building this. it might just be me so this might be something you can ignore.
i'm not sure if i'm just on a different go version or if some of the vendor directories didn't get committed with the last PR but it might be worth running go mod vendor again and making sure all the directories are added/tracked (i've had this get messed up on me before).
Co-authored-by: Krista LaFentres (she/her) <[email protected]>
chrisarcand
force-pushed
the
tfc-agents-rebased
branch
from
4d978df to
7921207
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds support for Terraform Cloud Agents, now that agent pools have a full resource lifecycle and can be managed via Terraform. Specifically this adds a
tfe_agent_poolresource and datasource (https://www.terraform.io/docs/cloud/api/agents.html) and allows configuring them for use in a Terraform Cloud workspace with the newexecution-modeattribute.Closes #204
Testing plan
execution_modeandagent_pool_idshould behave smoothly, allowing for continued use of the deprecatedoperationsargument or a seamless switch toexecution_mode. Their use should be mutually exclusive. The only known rough edge I have found is moving fromexecution_mode = "agent"back tooperations = true/falsefails schema validations, because of the limitations of validating existing state. This is acceptable though, as if you're already using execution_mode there is no reason to revert back to operations.terraform import tfe_agent_pool.name apool-xxxxExternal links
TODO
Deprecateoperations? Might save that for a separate change.