Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add branch attribute to vcs_repo block of tfe_workspace data source #290

Merged
merged 1 commit into from
Apr 19, 2021

Conversation

kgns
Copy link
Contributor

@kgns kgns commented Apr 13, 2021

Description

Currently we cannot get the VCS Repo Branch attribute value using tfe_workspace data source as opposed to being able to specify it using the resource version. This PR adds branch attribute to the data source and fixes this duality.

Output from acceptance tests

Full test timed out after 15m, so instead of increasing the timeout and trying again, I just ran individual test named TestAccTFEWorkspaceDataSource since the changes were only in this data source. However, vcs_repo block is not being tested in any tests, so this run does not mean anything.

$ TESTARGS="-run TestAccTFEWorkspaceDataSource" make testacc
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccTFEWorkspaceDataSource -timeout 150m
?       github.com/hashicorp/terraform-provider-tfe     [no test files]
=== RUN   TestAccTFEWorkspaceDataSource_basic
--- PASS: TestAccTFEWorkspaceDataSource_basic (9.90s)
PASS
ok      github.com/hashicorp/terraform-provider-tfe/tfe 9.907s
?       github.com/hashicorp/terraform-provider-tfe/version     [no test files]

@kgns kgns requested a review from a team April 13, 2021 14:34
@hashicorp-cla
Copy link

hashicorp-cla commented Apr 13, 2021

CLA assistant check
All committers have signed the CLA.

@chrisarcand chrisarcand merged commit 603fb22 into hashicorp:master Apr 19, 2021
@kgns kgns deleted the ws-vcs-branch-field branch April 21, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants