Allow Importing workspaces using workspace name #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonc
reviewed
Jan 5, 2022
| tfeClient := meta.(*tfe.Client) | ||
|
|
||
| s := strings.SplitN(d.Id(), "/", 2) | ||
| if len(s) >= 3 { |
There was a problem hiding this comment.
At most 2 strings will be returned by strings.SplitN(d.Id(), "/", 2)
tfe/resource_tfe_workspace.go
Outdated
| } | ||
|
|
||
| d.SetId(workspaceID) | ||
| return []*schema.ResourceData{d}, nil |
This changes the Importer function for the Workspace resource to handle passing an organization name and workspace name pair to import the workspace. If no pair is specified the importer function will assume an opaque external id was passed. An example import command looks as follows: terraform import tfe_workspace.test my-org-name/my-wkspace-name
brandonc
force-pushed
the
sebasslash/allow-wkspace-import-by-name
branch
from
4c3f400 to
3c5f110
Compare
brandonc
approved these changes
Jan 7, 2022
|
Nice! 👏🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for importing workspaces using a
<ORGANIZATION NAME>/<WORKSPACE NAME>nested combo. You can still pass a workspace external id.An example import command looks as follows:
How to test
To run acceptance tests:
TESTARGS="-run TestAccTFEWorkspace_import" make testaccTo smoke test:
Ensure you have the dev overrides set to the compiled binary of this PR in your
go/bin.