Add Organization Module Sharing Resource

[sebasslash]

Description

Hey Terraformers!

This PR introduces a new resource: tfe_organization_module_sharing which allows site admins to manage how module registries are shared across organizations. This is an admin only resource and thus can only be used in TFE. The resource has 3 total attributes, two of which are arguments and one is a computed attribute:

Arguments:

• organization - (Required) Name of the organization.
• module_consumers - (Required) Names of the organizations to consume the module registry.

(Computed) Attributes:

• consumer_ids - A map of organization names and their opaque, immutable IDs, which look like org-<RANDOM STRING>.

Testing plan

Run acceptance tests:

TESTARGS="-run TestAccTFEOrganizationModuleSharing" make testacc

Smoke test:

1. As always, you'll need to pull the changes from this PR locally and compile them. In my home folder I've created a dev overrides file ~/tfe_provider-dev.tfrc which I use when testing against the local provider binary:

provider_installation {
    dev_overrides {
        "hashicorp/tfe" = "$GOPATH/bin"
    }

    direct {}
}

2. Next we'll create a sample configuration. It's important to note an org's module registry DOES NOT NEED existing modules in order to be shared:

resource "tfe_organization" "producer" {
  name = "producer-org"
  email = "[email protected]"
}

resource "tfe_organization" "consumer_1" {
  name = "consumer-org-1"
  email = "[email protected]"
}

resource "tfe_organization" "consumer_2" {
  name = "consumer-org-2"
  email = "[email protected]"
}

resource "tfe_organization_module_sharing" "magic" {
  name = tfe_organization.producer.id
  module_consumers = [tfe_organization.consumer_1.id, tfe_organization.consumer_2.id]
}

3. Apply and watch the magic happen! Check the terraform.state file for any provider disobedience!
4. We can "delete" the resource in two ways: set module_consumers to an empty array (this will stop sharing an org's module registry) OR the expected way and delete the resource block in your configuration.

External links

• Module Sharing API documentation
• Module Sharing documentation

[brandonc]

Code review only- I haven't tested this yet -- overall very nice

[brandonc]

Should these be skipped for Terraform Cloud as well?

[brandonc]

Something may be amiss- is this entire function body supposed to be this line? Otherwise it looks like we are updating 2x

[brandonc]

Throughout the provider, org name is synonymous with id (both tfe_organization id/name attributes reflect the name and we don't expose the external id anywhere)

I think it would be less confusing to remove this attribute altogether.

[brandonc]

spelling

Suggested change

	return fmt.Errorf("Error reading organization %s mondule consumer list: %w", d.Id(), err)
	return fmt.Errorf("Error reading organization %s module consumer list: %w", d.Id(), err)

[brandonc]

this error looks scary you might want to say that we're having trouble deleting the organization module sharing

[brandonc]

Nice, it seems to work well! We'll have to consider how to mitigate resource drift when we add global_module_sharing to tfe_organization because when you turn it on, it clears the module sharing relationships. When you create module sharing relationships, it turns off global sharing