allow TF_TOKEN_... variables to specify host-specific credentials

[brandonc]

Description

This is a companion PR to a change to terraform that adds host specific env svc creds. It should be possible for tfe to use the same method when specifying credentials for a particular tfc host.

Testing plan

0. Build this code go build -o terraform-provider-tfe and update your CLI config to override it (see below)
1. Don't specify a token in your tfe provider configuration block
2. Remove or modify your CLI configuration credentials for the test host
3. Run terraform using an env var with the correct token value (see below)
4. This should work on Terraform 1.1 with local state. It would also work in latest Terraform built from source

I used this config:

provider "tfe" {
  hostname = "YOURHOST.com"
}

resource "tfe_organization" "test-organization" {
  name  = "my-org-name"
  email = "[email protected]"
}

resource "tfe_workspace" "test" {
  name         = "my-workspace-name"
  organization = tfe_organization.test-organization.name
  tag_names    = ["test", "app"]
}

with this command:

TF_CLI_CONFIG_FILE=.terraformrc TF_TOKEN_YOURHOST_COM="MY_REAL_TOKEN" terraform apply

with this CLI config:

provider_installation {
  # Use /home/developer/tmp/terraform-null as an overridden package directory
  # for the hashicorp/null provider. This disables the version and checksum
  # verifications for this provider and forces Terraform to look for the
  # null provider plugin in the given directory.
  dev_overrides {
    "hashicorp/tfe" = "/Users/brandonc/hashicorp/terraform-provider-tfe"
  }

  # For all other providers, install them directly from their origin provider
  # registries as normal. If you omit this, Terraform will _only_ use
  # the dev_overrides block, and so no other providers will be available.
  direct {}
}

External links

• Related PR

[annawinkler]

🌟 Tested and verified locally and it works!

[sebasslash]

Code looks fuego 🔥 👍 -- Last thing would be to update the Authentication section in this file: https://github.com/hashicorp/terraform-provider-tfe/blob/main/website/docs/index.html.markdown

[sebasslash]

Just curious here on readability: Would it be better to strings.Split() on = and compare each index rather than using ranges ?

[brandonc]

Split might be slightly more readable, but this version doesn't do any array allocation and is shared with terraform already. I think I'd like to keep it.

[brandonc]

@sebasslash I added the docs. Good call

[sebasslash]

LGTM 👍