Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor how workspace names resource arg filters for matches #698

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

laurenolivia
Copy link
Contributor

@laurenolivia laurenolivia commented Nov 18, 2022

Description

There was a feature request to pass partial matching to names arg using the * char.

Remember to:

Testing plan

  1. See docs on how to use names arg

Output from acceptance tests

Please run applicable acceptance tests locally and include the output here. See TESTS.md to learn how to run acceptance tests.

If you are an external contributor, your contribution(s) will first be reviewed before running them against the project's CI pipeline.

$ TESTARGS="-run TestAccTFEWorkspace" make testacc

...

@laurenolivia laurenolivia requested a review from a team as a code owner November 18, 2022 17:14
@laurenolivia laurenolivia marked this pull request as draft November 18, 2022 17:15
@laurenolivia laurenolivia marked this pull request as ready for review November 18, 2022 23:26
@laurenolivia laurenolivia force-pushed the laurenolivia/workspace-ids-wildcard branch from b0119b5 to 409a30e Compare November 29, 2022 22:44
Copy link
Collaborator

@brandonc brandonc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two chores: amend the documentation of data.tfe_workspace_ids to include details about the new wildcard functionality and include examples. Also add to the changelog. Looks great!

@laurenolivia laurenolivia force-pushed the laurenolivia/workspace-ids-wildcard branch from 409a30e to 256b884 Compare November 30, 2022 21:56
Copy link
Collaborator

@brandonc brandonc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

CHANGELOG.md Outdated Show resolved Hide resolved
@laurenolivia laurenolivia force-pushed the laurenolivia/workspace-ids-wildcard branch from 256b884 to 5cb2cee Compare November 30, 2022 22:12
@laurenolivia laurenolivia force-pushed the laurenolivia/workspace-ids-wildcard branch from 5cb2cee to 632be83 Compare November 30, 2022 22:13
@laurenolivia laurenolivia merged commit e885c0d into main Nov 30, 2022
@laurenolivia laurenolivia deleted the laurenolivia/workspace-ids-wildcard branch November 30, 2022 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants