-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tfe_saml_settings): add resource #970
feat(tfe_saml_settings): add resource #970
Conversation
…eDigestMethod fields in data source
…ed to updateSAMLSettings
testing on : #971 |
@uturunku1 can you please trigger the tests again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for following through on this!
There is one test failure to address:
I have used the documentation that you linked in the PR to compare and contrast with the settings that are adding here, and so far your implementation looks accurate!
Now with all your changes put together, I'd like to a smoke test the whole workflow for this feature. Would you mind adding a Testing Plan section in the PR description that includes instructions (a tf config sample, etc) on how to smoke test for this new feature? 🙏
@uturunku1 Thanks for reviewing the PR! I updated the ticket description with a test plan. Does that work for you? Let me know if I need to add anything else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
This PR adds the resource
tfe_saml_settings
. This change is required in order to add SAML settings support to the provider (documentation).Closes: #819
Testing plan
terraform apply
- resources will be created successfully.terraform apply
again. It will update the attributes already created (idp_cert
,slo_endpoint_url
,sso_endpoint_url
) and set the values for the new attributes defined (sso_api_token_session_timeout
,certificate
,private_key
,signature_digest_method
,attr_username
,authn_requests_signed
,).terraform destroy
. It will remove the resource from the state, disable the SAML single sign-on and set all the values to the default ones.External links
Output from acceptance tests