Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project ids to policy sets data source #974

Merged

Conversation

Netra2104
Copy link
Contributor

@Netra2104 Netra2104 commented Jul 20, 2023

Description

Project ids needs to be added to the policy set data source.

External links

Output from acceptance tests

Please run applicable acceptance tests locally and include the output here. See testing.md to learn how to run acceptance tests.

If you are an external contributor, your contribution(s) will first be reviewed before running them against the project's CI pipeline.

=== RUN   TestAccTFEPolicySetDataSource_basic
2023/07/26 11:13:33 [DEBUG] Configuring client for host "app.staging.terraform.io"
2023/07/26 11:13:33 [ERROR] Error reading CLI config or credentials file /Users/netra.mali/.terraformrc: open /Users/netra.mali/.terraformrc: no such file or directory
2023/07/26 11:13:33 [ERROR] Error reading CLI config or credentials file /Users/netra.mali/.terraform.d/credentials.tfrc.json: open /Users/netra.mali/.terraform.d/credentials.tfrc.json: no such file or directory
2023/07/26 11:13:33 [DEBUG] Service discovery for app.staging.terraform.io at https://app.staging.terraform.io/.well-known/terraform.json
--- PASS: TestAccTFEPolicySetDataSource_basic (34.69s)
PASS

=== RUN   TestAccTFEPolicySetDataSource_vcs
2023/07/26 11:14:49 [DEBUG] Configuring client for host "app.staging.terraform.io"
2023/07/26 11:14:49 [ERROR] Error reading CLI config or credentials file /Users/netra.mali/.terraformrc: open /Users/netra.mali/.terraformrc: no such file or directory
2023/07/26 11:14:49 [ERROR] Error reading CLI config or credentials file /Users/netra.mali/.terraform.d/credentials.tfrc.json: open /Users/netra.mali/.terraform.d/credentials.tfrc.json: no such file or directory
2023/07/26 11:14:49 [DEBUG] Service discovery for app.staging.terraform.io at https://app.staging.terraform.io/.well-known/terraform.json
    data_source_policy_set_test.go:122: Please set GITHUB_POLICY_SET_IDENTIFIER to run this test
--- SKIP: TestAccTFEPolicySetDataSource_vcs (1.79s)

Test ignored.
PASS

=== RUN   TestAccTFEPolicySetDataSource_notFound
--- PASS: TestAccTFEPolicySetDataSource_notFound (5.50s)
PASS

...

A small doc change to add a new attribute to the data source: project_ids

Screenshot 2023-07-26 at 10 00 20 AM

@Netra2104 Netra2104 force-pushed the Netra2104/TF-6351-add-project-ids-to-policy-sets-data-source branch 2 times, most recently from 7c97494 to 1cfb110 Compare July 24, 2023 18:41
@Netra2104 Netra2104 requested a review from a team July 25, 2023 16:54
@Netra2104 Netra2104 force-pushed the Netra2104/TF-6351-add-project-ids-to-policy-sets-data-source branch from ce9da8e to 4701de0 Compare July 26, 2023 15:17
@Netra2104 Netra2104 marked this pull request as ready for review July 26, 2023 15:31
@Netra2104 Netra2104 requested a review from a team as a code owner July 26, 2023 15:31
Copy link
Contributor

@laurenolivia laurenolivia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work ✨

Copy link

@ker-an ker-an left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@Netra2104 Netra2104 merged commit 6ab2665 into main Jul 26, 2023
@Netra2104 Netra2104 deleted the Netra2104/TF-6351-add-project-ids-to-policy-sets-data-source branch July 26, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants