QoL: Updating all the provider Golang code to include Description in preparation of documentation generation
#169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 17, 2022 18:24
… used by `*_cert` resources into `common_cert.go`
…n for documentation generation
bflad
approved these changes
Mar 17, 2022
detro
changed the title
Description in preparation of documentation genereationDescription in preparation of documentation genereation
detro
changed the title
Description in preparation of documentation genereationDescription in preparation of documentation generation
This was referenced Mar 18, 2022
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is extrapolated by #167, but makes the change-set more "manageable" for a good review process.
Additional to the addition of a lot of markdown-based
Descriptionstrings to theSchemas, this slightly re-organises the common part of the*_cert.goresources, so their schemas are set by the same utility methods (seecommon_cert.go).I have explicitly used
git mv resource_certificate.go common_cert.gobut somehow git decided it's still not a move and created a delete and a create 😢