Add support for adding Authority Key ID to tls_self_signed_cert
#212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regenerate doc Added "Subject Key Identifier" and "Authority Key Identifier" tests to `tls_locally_signed_cert` and `tls_self_signed_cert` resources
detro
force-pushed
the
detro/56-support_adding_authority-key-id_to_certificates
branch
from
d3d1bce to
cd07014
Compare
detro
deleted the
detro/56-support_adding_authority-key-id_to_certificates
branch
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #56
Closes #66
Initially the intention of this effort was to add
set_authority_key_idattribute to bothtls_locally_signed_certandtls_self_signed_cert.But during development I realised that
tls_locally_signed_certwas already generating a certificate with Authority Key ID correctly set, if the provided CA did have a Subject Key ID correctly set (#66 (comment)).So, this PR:
tls_self_signed_certtls_locally_signed_certandtls_self_signed_certto test their behaviour in this regard