Skip to content

Commit

Permalink
provider/openstack: Security Group Rules Fix
Browse files Browse the repository at this point in the history
This commit fixes how security group rules are read by Terraform and
enables them to be correctly removed when the rule resource is
modified.
  • Loading branch information
jtopjian committed Nov 6, 2015
1 parent fa471dd commit 0e9397f
Showing 1 changed file with 9 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -131,10 +131,10 @@ func resourceComputeSecGroupV2Read(d *schema.ResourceData, meta interface{}) err
d.Set("description", sg.Description)
rtm := rulesToMap(sg.Rules)
for _, v := range rtm {
if v["group"] == d.Get("name") {
v["self"] = "1"
if v["from_group_id"] == d.Get("name") {
v["self"] = true
} else {
v["self"] = "0"
v["self"] = false
}
}
log.Printf("[DEBUG] rulesToMap(sg.Rules): %+v", rtm)
Expand Down Expand Up @@ -283,12 +283,12 @@ func rulesToMap(sgrs []secgroups.Rule) []map[string]interface{} {
sgrMap := make([]map[string]interface{}, len(sgrs))
for i, sgr := range sgrs {
sgrMap[i] = map[string]interface{}{
"id": sgr.ID,
"from_port": sgr.FromPort,
"to_port": sgr.ToPort,
"ip_protocol": sgr.IPProtocol,
"cidr": sgr.IPRange.CIDR,
"group": sgr.Group.Name,
"id": sgr.ID,
"from_port": sgr.FromPort,
"to_port": sgr.ToPort,
"ip_protocol": sgr.IPProtocol,
"cidr": sgr.IPRange.CIDR,
"from_group_id": sgr.Group.Name,
}
}
return sgrMap
Expand Down

0 comments on commit 0e9397f

Please sign in to comment.