Meta Issue: Migrate to upstream awslabs/aws-sdk-go

[catsby]

This is a meta issue to track our migration of AWS resources to the upstream version of aws-sdk-go at https://github.com/awslabs/aws-sdk-go.

If anyone would like to contribute, see my previous PRs (linked below) for examples of the general work to be done in each PR. To aid us here, there are upstream versions of tags.go and structure.go, with the _sdk prefix. In them are the awslabs version of the methods contained in the originals, so tagsToMap becomes tagsToMapSDK, etc.

Resource	PR	Merged
autoscaling group	#1513	✓
db instance	#1510	✓
db parameter group	#1510	✓
db security group	#1510	✓
db subnet group	#1510	✓
eip	#1408	✓
elb	#1532	✓
instance	#1558	✓
internet gateway	#1407	✓
key pair	#1397	✓
launch configuration	#1553	✓
main route table association	#1489	✓
network acl	#1509	✓
network_interface	#1411	✓
route53 record	#1519	✓
route53 zone	#1519	✓
route table	#1489	✓
route table association	#1489	✓
s3 bucket	#1520	✓
security group	#1446	✓
subnet	#1398	✓
vpc	#1486	✓
vpc peering connection	#1522	✓
vpn gateway	#1531	✓

Questions?
Missing something?
Ask and I'm here to help 😄

[ocxo]

@catsby I'm trying to take a shot at converting the instance resource but hitting errors like

builtin/providers/aws/resource_aws_instance.go:322: undefined: "github.com/awslabs/aws-sdk-go/service/ec2".RunInstancesRequest
builtin/providers/aws/resource_aws_instance.go:359: undefined: "github.com/awslabs/aws-sdk-go/aws".Integer
builtin/providers/aws/resource_aws_instance.go:799: undefined: "github.com/awslabs/aws-sdk-go/aws".StringValue

Could you help point me in the right direction?

[ocxo]

Figured it out... it helps if I use the correct methods 😄

[ocxo]

@catsby just in case you were waiting for me on the instance conversion, I moved on to route53 (which you got covered) and haven't come back to instance yet, feel free to bring that over. Thanks again for all this!

[catsby]

No worries, I'm doing Instance today and then we'll be done!

[catsby]

Everything is merged!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.