provider/aws: Convert VPN Gateway to upstream #1531
Conversation
| vpnGateway := &resp.VPNGateways[0] | ||
| return vpnGateway, *vpnGateway.State, nil | ||
| vpnGateway := resp.VPNGateways[0] | ||
| return vpnGateway, "", nil |
There was a problem hiding this comment.
Aren't we supposed to return the state here?
There was a problem hiding this comment.
We were returning it, but never using it. It's kind of a funky remnant the original contributor got from copying LC. I should just overhaul the whole method...
|
LGTM generally, with 1 question inline. |
|
@phinze I refactored to remove that refresh func that wasn't being used as a refresh func, take another look when you can |
|
Cool LGTM 🚢 |
provider/aws: Convert VPN Gateway to upstream
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
No description provided.